Extract purchase-common module (RND-1965)#2942
Draft
hugokallstrom wants to merge 1 commit into
Draft
Conversation
Create a new app/purchase-common library module containing shared purchase screens, use cases, models, and GraphQL operations that are product-agnostic. This unblocks adding new in-app purchase products (car, etc.) without duplicating tier selection, summary, signing, success, and failure screens. Moved from feature-purchase-apartment to purchase-common: - SelectTier, PurchaseSummary, Signing, PurchaseSuccess, PurchaseFailure screens, view models, and presenters - AddToCartAndStartSignUseCase, PollSigningStatusUseCase - TierOfferData, SelectTierParameters, SummaryParameters, SigningParameters, SigningStart, SigningPollResult, SigningStatus - ShopSessionCartEntriesAdd / ShopSessionStartSign / ShopSessionSigning mutations + ProductOfferFragment feature-purchase-apartment now depends on purchase-common. Apartment behavior is unchanged. Also includes UX polish on the shared SelectTier screen exposed by the multi-product use case: - Hide deductible dropdown entirely when only a single option exists (instead of rendering it disabled) - Pre-select the currently-confirmed tier and deductible in the dialog radio groups so the existing choice is visible when reopening Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
5 tasks
hugokallstrom
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app/purchase-commonas a library module containing tier selection, summary, signing, success, and failure screens plus their use cases, models, and GraphQL operationsfeature-purchase-apartmentslimmed down to just the apartment-specific form + use cases, now depending onpurchase-commonWhat moved
SelectTier,PurchaseSummary,Signing,PurchaseSuccess,PurchaseFailureAddToCartAndStartSignUseCase,PollSigningStatusUseCaseTierOfferData,SelectTierParameters,SummaryParameters,SigningParameters,SigningStart,SigningPollResult,SigningStatusShopSessionCartEntriesAdd,ShopSessionStartSign,ShopSessionSigning,ProductOfferFragment(renamed withPurchaseprefix)UX polish on shared SelectTier
Test plan
🤖 Generated with Claude Code