Allow json schemer to validate with external refs#115
Merged
ollietulloch merged 3 commits intomainfrom Feb 25, 2026
Merged
Conversation
❌MegaLinter analysis: Error
Detailed Issues❌ REPOSITORY / checkov - 1 error❌ REPOSITORY / devskim - 1 error❌ REPOSITORY / grype - 10 errors❌ COPYPASTE / jscpd - 3 errors❌ REPOSITORY / kics - 5 errors❌ SPELL / lychee - 5 errors❌ REPOSITORY / secretlint - 1 error❌ REPOSITORY / trivy - 1 error❌ YAML / yamllint - 2 errors
|
timgentry
approved these changes
Feb 25, 2026
Contributor
timgentry
left a comment
There was a problem hiding this comment.
Approved, thanks @ollietulloch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What?
Fixes a bug in
JsonSchemaValidatorwhereJSONSchemerwould not validate when the schema included external$refWhy?
So external
RefResolverscan be used when store data is validated against a versioned schemaHow?
For now, passing a default
ref_resolverof{}toJSONSchemerTesting?
Added example schema and test coverage to
JsonSchemaValidatorTestAnything Else?
As a bugfix, this constitutes a patch revision change. We may want to extend this logic and allow
RefResolversto define their ownto_schema, which could then be passed as aref_resolvertoJSONSchemer.