Don't use a mem reference for setting object fields#1324
Open
Aidan63 wants to merge 1 commit intoHaxeFoundation:masterfrom
Open
Don't use a mem reference for setting object fields#1324Aidan63 wants to merge 1 commit intoHaxeFoundation:masterfrom
Aidan63 wants to merge 1 commit intoHaxeFoundation:masterfrom
Conversation
Member
|
Will this have an impact on performance? |
Contributor
Author
|
Probably, the removed code means updating a field which contains an object will use runtime lookup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mem reference erases the underlying type to just
hx::Object*, this is a problem when you try and set a field of a function type in a host class from a script. Script closures and functions do not extend the new callable type so by using this type erased pointer is assigned a not callable object to a callable object pointer, which then causes memory errors when invoking it.