Use quotes for db and table names that contain non-alphanumeric chars#18
Merged
Conversation
dawsontoth
approved these changes
May 18, 2026
Contributor
dawsontoth
left a comment
dawsontoth
left a comment
There was a problem hiding this comment.
I like it! Mind fixing the commit title prefix for conventional commits?
cb1kenobi
force-pushed
the
dts-quote-db-table-names
branch
2 times, most recently
from
051fb2f to
e0c8b67
Compare
cb1kenobi
force-pushed
the
dts-quote-db-table-names
branch
from
e0c8b67 to
a0e4774
Compare
Member
Author
|
@dawsontoth done! When can we get rid of conventional commits? |
Contributor
|
Why? It drives the semantic versioning here. |
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you have a database or table name that contains a dash, it causes invalid syntax in the generated
globalTypes.d.tsfile.