feat(draftassist): inject DraftAssistHost; stop spawning from NewHTTPHandler - #201
Merged
Merged
Conversation
…PATH Co-authored-by: Cursor <cursoragent@cursor.com>
…njects Fake Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hamix-draft-agentviaHAMIX_DRAFT_AGENT_BIN, executable sibling, then PATH.NewHTTPHandlertakes an injectedDraftAssistHost; the smoke test supplies Fake so CI never spawns the sidecar.CURSOR_API_KEYis missing (P2 removes that fallback).Test plan
.\scripts\check.ps1 -GoOnlygh stack mergefromfeat/draft-assist-inject(full stack: feat(draftassist): inject DraftAssistHost; stop spawning from NewHTTPHandler #201 → feat(draftassist): fail taskapi boot unless sidecar is healthy #202 → docs(draftassist): require CURSOR_API_KEY; honest compose banner when taskapi is down #203)Notes