This repository was archived by the owner on May 22, 2020. It is now read-only.
RUN-5674 | BrowserView creates multiply window/close events #2#985
Open
tomer-openfin wants to merge 6 commits intoHadoukenIO:developfrom
Open
RUN-5674 | BrowserView creates multiply window/close events #2#985tomer-openfin wants to merge 6 commits intoHadoukenIO:developfrom
tomer-openfin wants to merge 6 commits intoHadoukenIO:developfrom
Conversation
|
openfin-github-bot
bot
added
auto testing started
Git
Asars used for testingTest results
|
openfin-github-bot
bot
added
auto testing done
Contributor
|
Got a conflict |
openfin-github-bot
bot
added
auto testing started
Git
Asars used for testingTest results
|
openfin-github-bot
bot
added
auto testing done
Contributor
|
This will likely conflict with #976, so may want to wait for that to go in first? |
rdepena
previously approved these changes
Oct 16, 2019
licui3936
reviewed
Oct 17, 2019
Contributor
Author
|
@MichaelMCoates I don't mind waiting. |
openfin-github-bot
bot
added
auto testing started
Git
Asars used for testingTest results
|
openfin-github-bot
bot
added
auto testing done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
extending previous PR for this issue by refactoring the logic and adding .isDestroyed check.
Checklist
npm testpasses