Point the documented pins at 1.6.0 - #67
Conversation
The version landed with the feature rather than in a release commit of its own, so the four pins a consumer copies out of this repository -- the pre-commit `rev`, the lefthook `ref`, and the two `cargo install --tag` lines -- still named 1.5.0 at the tag that carries 1.6.0. A reader following the README at that tag installs a binary without the seam the tag exists for. No code, and nothing here is read by a gate: `no-stale-hook-pins` reads a consuming tree, not this one own documentation, which is why these went stale without anything saying so.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change updates all documented Uphold version references from ChangesUphold version reference update
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This is a localized update to documented version pins, with no code or runtime behavior changes. No actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
=======================================
Coverage 89.88% 89.88%
=======================================
Files 33 33
Lines 10305 10305
=======================================
Hits 9263 9263
Misses 1042 1042 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 participants
The version landed with the feature in #66 rather than in a release commit of its own, so the four pins a consumer copies out of this repository still named 1.5.0 at the tag that carries 1.6.0: the pre-commit
rev, the lefthookref, and the twocargo install --taglines. A reader following the README at that tag installs a binary without the seam the tag exists for.No code. Nothing here is read by a gate either --
no-stale-hook-pinsreads a consuming tree rather than this repository own documentation, which is exactly why these went stale with every check still green.The
v1.6.0tag moves onto this commit once it merges. It is minutes old, no consumer references it yet, and no workflow triggers on tags, so moving it now costs nothing and stops costing nothing shortly after.Summary by CodeRabbit