Skip to content

Comments

Brussels | itp-2026-1 | Sarah Almadi | Week 1 | Wireframe to Web Code#77

Open
sarahalmadi wants to merge 8 commits intoHackYourFutureBelgium:mainfrom
sarahalmadi:feature/wireframe
Open

Brussels | itp-2026-1 | Sarah Almadi | Week 1 | Wireframe to Web Code#77
sarahalmadi wants to merge 8 commits intoHackYourFutureBelgium:mainfrom
sarahalmadi:feature/wireframe

Conversation

@sarahalmadi
Copy link

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Briefly explain your PR.

Questions

Do you have any tips for debugging accessibility issues when Lighthouse doesn’t clearly show which element is failing?

@fgsumer
Copy link

fgsumer commented Feb 24, 2026

✅ Overall: very clean structure, excellent use of CSS Grid and good commit messages.

Just a couple of polish fixes.

  • The footer is fixed but not guaranteed to stick to the bottom. Try this one:
footer {
  position: fixed;
  bottom: 0;
  left: 0;
}
  • In href="#", technically # is a link, but for this exercise, we expect a real external resource.
  • oklch(7 0 0) is almost black. White text on near-black is fine for contrast. But visually it’s heavy. Not wrong — just something to note.

@sarahalmadi
Copy link
Author

_Thank you so much for your time and effort , I will work on these changes to get the best Results👾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants