Skip to content

Salem Ba-rabuod#4

Open
Barboud wants to merge 1 commit intoHackYourAssignment:mainfrom
Barboud:main
Open

Salem Ba-rabuod#4
Barboud wants to merge 1 commit intoHackYourAssignment:mainfrom
Barboud:main

Conversation

@Barboud
Copy link
Copy Markdown

@Barboud Barboud commented Mar 10, 2026

No description provided.

@github-actions
Copy link
Copy Markdown

📝 HackYourFuture auto grade

Assignment Score: 100 / 100 ✅

Status: ✅ Passed
Minimum score to pass: 50
🧪 The auto grade is experimental and still being improved

Test Details
Vitest unit test results:

✅ post.sh: Script exists
✅ post.sh: Create user John Doe
✅ patch.sh: Script exists
✅ patch.sh: Correct the email address
✅ get.sh: Script exists
✅ get.sh: Retrieve user John Doe details
✅ delete.sh: Script exists
✅ delete.sh: Delete user John Doe
✅ get.sh: Verify user John Doe has been deleted
✅ Uses the correct base URL
✅ URL includes the nobelPrizeYear query parameter
✅ URL includes the nobelPrizeCategory query parameter
✅ URL includes the offset query parameter
✅ URL includes the limit query parameter
✅ Omits the nobelPrizeYear when set to "all"
✅ Omits the nobelPrizeCategory when set to "all"
✅ Includes the sort query parameter set to desc

Total passed: 17
Total failed: 0
Killed

@remarcmij remarcmij self-assigned this Mar 11, 2026
Copy link
Copy Markdown

@remarcmij remarcmij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Barboud, all looks good, some minor comments below, but well done.

#!/bin/bash
curl 'http://localhost:3000/users/11' \
-X DELETE \
-H 'Content-Type: application/json' No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are not sending any content (no body), so you don't need the Content-Type header. The server simply ignores it.

#!/bin/bash
curl 'http://localhost:3000/users/11' \
-X GET \
-H 'Content-Type: application/json' No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

import { fetchData } from "./fetcher.js";

const API_BASE_URL = 'https://api.nobelprize.org/2.1';
const API_BASE_URL = "https://api.nobelprize.org/2.1";
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your editor is set up to use double quotes for strings, whereas the original code uses single quotes. That's why we see this in the PR as a change. To avoid such unnecessary "diffs", it is important that teams agree on a common standard.

params.append("nobelPrizeCategory", filters.category);
}

url = `${API_BASE_URL}/nobelPrizes?${params.toString()}`;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@remarcmij remarcmij added the Reviewed This assignment has been reivewed by a mentor and a feedback has been provided label Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed This assignment has been reivewed by a mentor and a feedback has been provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants