Shadi A.

[shmoonwalker]

finish week 9 assignment

[JQnetherlands]

Hello,

I will start with the good news and after with the nice to haves, Congratulation you have passed task 1 and task 2 successfully, your code is well structured , it is easy to follow and most important to understand , keep the good job.

The only feedback I have to give you so you can grow as a stonger developer is the next one. In you task 2 services.js I can clearly see you do understand what the code is supposed to do, you show that you understand perfectly the documentation of URLSearchParams. On the other hand, the code could be much shorter if for example you use object destructuring how and where you could use it in your code?

I invite you to start to think how you can make your code doing the same with less, your code does it really well but could be shorter, that is something that come with time but it is good you start thinking about it from now on, again , congratulation you did an amazing job.

[github-actions]

📝 HackYourFuture auto grade

Assignment Score: 100 / 100 ✅

Status: ✅ Passed
Minimum score to pass: 50
🧪 The auto grade is experimental and still being improved

Test Details

Vitest unit test results:

✅ post.sh: Script exists
✅ post.sh: Create user John Doe
✅ patch.sh: Script exists
✅ patch.sh: Correct the email address
✅ get.sh: Script exists
✅ get.sh: Retrieve user John Doe details
✅ delete.sh: Script exists
✅ delete.sh: Delete user John Doe
✅ get.sh: Verify user John Doe has been deleted
✅ Uses the correct base URL
✅ URL includes the nobelPrizeYear query parameter
✅ URL includes the nobelPrizeCategory query parameter
✅ URL includes the offset query parameter
✅ URL includes the limit query parameter
✅ Omits the nobelPrizeYear when set to "all"
✅ Omits the nobelPrizeCategory when set to "all"
✅ Includes the sort query parameter set to desc

Total passed: 17
Total failed: 0
Killed