Conversation
mo92othman
left a comment
mo92othman
left a comment
There was a problem hiding this comment.
Hi @hannahwn ! Thanks for submitting the assignment! Nice job on this assignment! Well done!
I’ve left a few comments. Let me know if anything is unclear.
| let UserInput = prompt('Enter an year: '); | ||
|
|
||
| let year = Number(UserInput); |
There was a problem hiding this comment.
Nice clear variable names. Since these variables are not reassigned, you could use const instead of let to make that clearer. This is a small best-practice improvement.
| else if(year % 100 ===0 || !year % 4 ===0){ | ||
|
|
||
| console.log('no,' +year+' is not a leap year'); | ||
| } |
There was a problem hiding this comment.
There is a small mistake in this part. !year % 4 === 0 does not mean “year is not divisible by 4”.
year is a number → usually truthy (Why is it a number? check line 12 in your code)
!year becomes false
false % 4 becomes 0
0 === 0 is true
Example: with input 2024, your code can end up printing “not a leap year”, but 2024 is a leap year.
Could you think of a way to fix this?
One more thing in this part, since that detials matters. console.log('no,' +year+' is not a leap year');
The n in no should be Upper case.
| let year = Number(UserInput); | ||
|
|
||
|
|
||
| if(year<1 || year >9999 || isNaN(year)){ |
There was a problem hiding this comment.
Good job using isNaN(year) to handle invalid input 👍
| console.log('Invalid Year');} | ||
|
|
||
| else if(year % 400 === 0 ){ | ||
| console.log('Yes,' +year+' is a leap year'); | ||
| } | ||
| else if(year % 100 ===0 || !year % 4 ===0){ | ||
|
|
||
| console.log('no,' +year+' is not a leap year'); | ||
| } |
There was a problem hiding this comment.
One small style note: consistent indentation (spacing at the beginning of lines) makes the code easier to read. Try to align if / else blocks consistently.
| console.log('Invalid Year');} | |
| else if(year % 400 === 0 ){ | |
| console.log('Yes,' +year+' is a leap year'); | |
| } | |
| else if(year % 100 ===0 || !year % 4 ===0){ | |
| console.log('no,' +year+' is not a leap year'); | |
| } | |
| console.log('Invalid Year'); | |
| } else if (year % 400 === 0) { | |
| console.log('Yes, ' + year + ' is a leap year'); | |
| } else if (year % 100 === 0 || !year % 4 === 0) { | |
| console.log('No, ' + year + ' is not a leap year'); | |
| } | |
| } | ||
|
|
||
|
|
||
| if (foundCorrectUser === true) { |
There was a problem hiding this comment.
Small style note, what you wrote is correct. But you can also write it in another way:
since foundCorrectUser is already a boolean, you can simply write if (foundCorrectUser) {. Both are correct.
| const eurAmountInput = prompt("Enter amount in EUR: "); | ||
| const eurAmountNum = Number(eurAmountInput); | ||
| if (Number.isNaN(eurAmountNum) || eurAmountNum > 0) { | ||
| if (Number.isNaN(eurAmountNum) || eurAmountNum < 0) { |
There was a problem hiding this comment.
Here you can also reject 0. Using <= 0 instead of < 0 would handle this edge case.
| } else { | ||
| const eurAmount = usdAmountNum / eur_usd_rate; | ||
| const eurAmount = usdAmountNum / EUR_USD_RATE; | ||
| console.log(usdAmountNum.toFixed(2) + ' USD is equal to ' + usdAmountNum.toFixed(2) + ' EUR.'); |
There was a problem hiding this comment.
Here you are printing the USD amount twice. You should display the calculated EUR amount instead.
| } else { | ||
| } | ||
| else if (menuSelection === "3"){ | ||
| console.log("The current exchange rate is 1 EUR = 1.1643 USD."); |
There was a problem hiding this comment.
Small improvement: instead of hardcoding the exchange rate value, you could use the EUR_USD_RATE constant here. This keeps the output consistent and makes the code easier to maintain if the rate changes later for example.
| console.log("The current exchange rate is 1 EUR = 1.1643 USD."); | ||
| } | ||
| else { | ||
| console.log("Invalid selection. Please choose either 1 or 2."); |
There was a problem hiding this comment.
Here in line 41. The menu has three options. The invalid selection message should also mention options 1, 2, or 3.
2 participants
submitting assingment