You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
Hello Jawad
Your class is well done, your code achieve all the goals, you handle all the edges cases. The only feedback I have is that you can put more comments in your code for your future you or colleague. I see you do understand the use of the modulo %, it is a very good trick in javaScript and make you write much less logic of your own.
About task 2, I mocked the question with my own MokeQuestions.js, cos I don’t have right now a credit card valid for getting an API key, I trust you try your proyect with your own Key, with my moke file your code indeed work as expected, I like the colours that you use, and more important, you make very clear what is the question, the good answer, and the wrong answer.
Congratulations for the good work! I wish you all the best for your career!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReviewedThis assignment has been reivewed by a mentor and a feedback has been provided
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.