Conversation
Template and template image pending change
A per-person pipeline with two independent concurrency-limited pools where each person moves from Tito to email on their own as soon as a slot is free, with no batch boundaries.
ReehalS
had a problem deploying
to
development
GitHub Actions
Failure
* Judge invites! * Fix image URL and error handling for sending emails * Document browser preview csv parser * Throw error for missing email ENV vars * cleaned code and updated email * fixed email template --------- Co-authored-by: michelleyeoh <michellew.yeoh@gmail.com> Co-authored-by: michelleyeoh <74385095+michelleyeoh@users.noreply.github.com>
A per-person pipeline with two independent concurrency-limited pools where each person moves from Tito to email on their own as soon as a slot is free, with no batch boundaries.
…is/hackdavis-hub into 376-mentor-email-invites
…/HackDavis/hackdavis-hub into 376-mentor-email-invites" This reverts commit 458d2db, reversing changes made to fd85880.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Nodemailer + Tito to send mentors invites
Modified the admissions portal code to make it even faster. Rather than having it be batches of 10/20 people processed in parallel, I made it a queue based system where there are always 20 people processing for Tito invites, and always 10 people's whose emails are being sent in parallel. I.e. if 20 people are processing for Tito invites right now, if one finishes, their place in the queue is immediately taken up by another person in waiting.
This will be very easy to modify in my next PR for sending hacker emails (required because the current version was nuked in #406)
The UI for invites is being consolidated into 1 page with sub tabs for Judges, Mentors and Hackers (future).
Each one will also allow sending invites to either a single person or a CSV uploaded list of people.
Closes #376
DO NOT MERGE YET. LET ME KNOW WHEN #406 IS MERGED. I will rebase from main at that time. This contains commits from #406 and ideally shouldn't have to show up a second time on the git tree.