Feature/79895 Split build and release in two separate Github Actions jobs#26
Open
bogdandina wants to merge 9 commits into
Open
Feature/79895 Split build and release in two separate Github Actions jobs#26bogdandina wants to merge 9 commits into
bogdandina wants to merge 9 commits into
Conversation
Add a zizmor job to ci.yml that runs on every PR and push to main, auditing all workflow files for unpinned actions, template injection, excessive permissions, and other insecure patterns via zizmorcore/zizmor-action (SARIF results uploaded to GitHub Security tab). Pin every uses: reference across all four shared workflows to an immutable commit SHA with a human-readable version comment, eliminating the supply-chain risk of mutable tags being silently redirected to malicious commits. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
haphut
reviewed
May 21, 2026
| fail_ci_if_error: true | ||
| report_type: test_results | ||
|
|
||
| - name: Build artifact |
Contributor
There was a problem hiding this comment.
Why do we build and upload the .jar file into artifacts?
Contributor
There was a problem hiding this comment.
Can we remove these two steps?
haphut
reviewed
May 21, 2026
| persist-credentials: false | ||
|
|
||
| - name: Install Node | ||
| # zizmor:ignore[cache-poisoning] Node binary tool-cache is implicit and cannot be disabled; no npm package cache is configured |
Contributor
There was a problem hiding this comment.
Are you sure this zizmor:ignore is needed after removing the cache parameter? Maybe try without this line?
haphut
approved these changes
May 21, 2026
Contributor
haphut
left a comment
haphut
left a comment
There was a problem hiding this comment.
Great job! I'm approving even though I'd like to see some changes. If you agree with the changes, you can merge after them. Otherwise let's discuss.
Contributor
|
I think you can close the Zizmor PR as the commits are already here, as you mentioned, and they look fine as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.