build: add commitlint for angular convention#936
Conversation
|
@sponce your views on this ? |
|
All fine to me. @EdwardMoyse any objection to merging this ? |
|
I'm a bit nervous that I' m going to get flagged the whole time. ;-) But actually, does this work? I just tried locally And probably we'd want something in |
|
I checked this locally. Right now this PR only adds the two commitlint packages and lockfile changes. There is no commitlint config, no package script, no So this does not currently enforce commit messages or PR titles. It needs the config and hook/CI wiring before it does what the description says. |
|
@EdwardMoyse @rx18-eng I have puhsed the changes and would appreciate a re-review! |
Description
This PR integrates
@commitlint/cliand@commitlint/config-conventionalto enforce the Angular commit convention across the project.As mentioned in the
Contributing section of our README, all commits must follow this format. Adding this tooling automatically validates commit messages and PR titles, preventing badly formatted commits from merging intomain.