Skip to content

build: add commitlint for angular convention#936

Open
lavjeetrai wants to merge 2 commits into
HSF:mainfrom
lavjeetrai:build/commitlint
Open

build: add commitlint for angular convention#936
lavjeetrai wants to merge 2 commits into
HSF:mainfrom
lavjeetrai:build/commitlint

Conversation

@lavjeetrai

Copy link
Copy Markdown
Contributor

Description

This PR integrates @commitlint/cli and @commitlint/config-conventional to enforce the Angular commit convention across the project.

image

As mentioned in the Contributing section of our README, all commits must follow this format. Adding this tooling automatically validates commit messages and PR titles, preventing badly formatted commits from merging into main.

@lavjeetrai

Copy link
Copy Markdown
Contributor Author

@sponce your views on this ?

@sponce

sponce commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

All fine to me. @EdwardMoyse any objection to merging this ?

@EdwardMoyse

Copy link
Copy Markdown
Member

I'm a bit nervous that I' m going to get flagged the whole time. ;-)

But actually, does this work? I just tried locally

emoyse@umassmacbookprom1pro1 phoenix % yarn commitlint --from HEAD~1 --to HEAD --verbose

⧗   --- input ---
Just adding some test
✖   Please add rules to your `commitlint.config.js`

And probably we'd want something in .husky too?

@rx18-eng

Copy link
Copy Markdown
Collaborator

I checked this locally. Right now this PR only adds the two commitlint packages and lockfile changes.

There is no commitlint config, no package script, no .husky/commit-msg as @EdwardMoyse said and no CI/PR-title check that runs it. With just these changes, commitlint fails with Please add rules to your commitlint.config.js, even for build: add commitlint for angular convention.

So this does not currently enforce commit messages or PR titles. It needs the config and hook/CI wiring before it does what the description says.

@lavjeetrai

Copy link
Copy Markdown
Contributor Author

@EdwardMoyse @rx18-eng I have puhsed the changes and would appreciate a re-review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants