eCLM-ParFlow: Normalize ParFlow source term over the gridcell - #132
Draft
s-poll wants to merge 1 commit into
Draft
eCLM-ParFlow: Normalize ParFlow source term over the gridcell#132s-poll wants to merge 1 commit into
s-poll wants to merge 1 commit into
Conversation
- qflx_parflow_col stayed spval on lake, glacier, wetland and non-pervious urban columns, so that the flux was the mean over the hydrologically active fraction while ParFlow applies it over the whole cell - zero qflx_parflow_col on all columns before the assignment loops, so that sumwt reaches 1 - drop the spvalto 0 loop after c2g, unreachable once nothing is spval - see details in #131
Member
|
CI failure is due to silent failures in installing 
This issue has been recently reported in awalsh128/cache-apt-pkgs-action#221 ; let's wait for the maintainer to fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #131.
Summary
qflx_parflow_colis left atspvalon every column thatParFlowDrainagedoes not assign, e.g. lake, glacier, wetland and the non-pervious urban types.c2gexcludes those from its denominator as well as its numerator, so that the flux handed to ParFlow was the mean over the hydrologically active fraction while ParFlow applies it over the whole cell. Zeroing the array before the assignment loops makes the non-contributing columns count as explicit zeros, restoring full-gridcell normalization and making thespval to 0workaround inlnd2atmModunnecessary.Details
See #131 for details
Side effects
QPARFLOWhistory output reports0rather than the fill value on non-contributing columns, since the array is now zeroed every timestep rather than left at its initialspvalvalue.