Skip to content

perf(download): skip re-installing loader if identical version patch … #6594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fatelove42 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf(download): skip re-installing loader if identical version patch … #6594

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions HMCLCore/src/main/java/org/jackhuang/hmcl/download/DefaultDependencyManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,58 @@ public Task<GameInstanceManifest> installLibraryAsync(String gameVersion, GameIn
.withStage(String.format("hmcl.install.%s:%s", libraryId, libraryVersion));
}

private static boolean isLoaderLibrary(Library library, String libraryId) {
if (library == null || library.groupId() == null) return false;
String groupId = library.groupId().toLowerCase(java.util.Locale.ROOT);
String targetId = libraryId.toLowerCase(java.util.Locale.ROOT);
return switch (targetId) {
case "forge" -> groupId.startsWith("net.minecraftforge");
case "neoforge" -> groupId.startsWith("net.neoforged");
case "optifine" -> "optifine".equals(groupId);
case "fabric" -> groupId.startsWith("net.fabricmc");
case "quilt" -> groupId.startsWith("org.quiltmc");
case "legacyfabric" -> groupId.startsWith("net.legacyfabric");
case "cleanroom" -> groupId.startsWith("zone.rong");
default -> groupId.contains(targetId);
};
}

private boolean isLibraryUpToDateAndIntact(GameInstanceManifest baseVersion, RemoteVersion libraryVersion) {
if (!repository.hasInstance(baseVersion.id())) {
return false;
}

try {
GameInstanceManifest existingManifest = repository.getInstanceManifest(baseVersion.id());
String currentGameVersion = repository.getGameVersion(existingManifest).orElse(null);
if (!java.util.Objects.equals(currentGameVersion, libraryVersion.getGameVersion())) {
return false;
}

boolean hasMatchingPatch = existingManifest.getPatches().stream()
.anyMatch(patch -> libraryVersion.getLibraryId().equals(patch.id())
&& java.util.Objects.equals(patch.version(), libraryVersion.getSelfVersion()));
if (!hasMatchingPatch) {
return false;
}

GameInstanceManifest.Resolved resolved = repository.getResolvedInstanceManifest(baseVersion.id());
boolean needsRepair = resolved.launchManifest().getLibraries().stream()
.filter(lib -> isLoaderLibrary(lib, libraryVersion.getLibraryId()))
.anyMatch(lib -> GameLibrariesTask.shouldDownloadLibrary(repository, existingManifest, lib, false));

return !needsRepair;
} catch (Exception ignored) {
return false;
}
}

@Override
public Task<GameInstanceManifest> installLibraryAsync(GameInstanceManifest baseVersion, RemoteVersion libraryVersion) {
if (isLibraryUpToDateAndIntact(baseVersion, libraryVersion)) {
return Task.completed(baseVersion);
}

AtomicReference<GameInstanceManifest> removedLibraryVersion = new AtomicReference<>();

return removeLibraryAsync(baseVersion, libraryVersion.getLibraryId())
Expand Down