fix(ci): sync uv.lock and let release-please update it on every release - #94
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Docker build on
mainfailed after merging PR #93 (release-please):release-please bumped
pyproject.tomlto2.23.0butuv.lockstill recorded the project version2.22.0, souv sync --lockedin the Dockerfile rejected the stale lockfile. This will happen on every release.Changes
uv.lock: regenerate project version entry (2.22.0->2.23.0) — fixes the current failed build..github/release-please-config.json(new): release-please manifest config with anextra-filesTOML updater (JSONPath intouv.lock) so every release PR also updates the project version insideuv.lock..github/release-please-manifest.json(new): version seed".": "2.23.0"(matches the currentv2.23.0tag)..github/workflows/release-please.yml: migrate from simple mode (release-type: python) to manifest mode (config-file/manifest-file) —extra-filesis only supported in manifest mode..github/workflows/ci.yml: adduv lock --checkguard so lockfile drift fails CI in seconds, before the Docker build.Validation
uv.lockwithjsonpath-plus(the library release-please uses): exactly 1 match (/package/8/version).GenericTomlfrom therelease-pleasepackage: updates exactly 1 line, format preserved.2.24.0+ updater output) ->uv lock --checkpasses.uv sync --locked --no-install-project --extra apipasses locally.pre-commit run --files ...(check-yaml, check-toml, prettier, whitespace) passes.The combined JSONPath filter (
@.name == 'ciberwebscan' || @.name.value == 'ciberwebscan') handles both the tagged and untagged TOML representations used by release-please's parser.