Fix/config 001 validation error signal - #89
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix CONFIG-001 by propagating configuration validation failures from
ConfigLoaderthroughConfigServiceto the CLI and API.Previously, an invalid configuration was rejected by Pydantic and silently replaced with the default configuration, while the CLI reported the configuration as loaded and the API returned no indication that validation had failed.
This change:
validation_errortoConfigLoaderto expose validation failures.ConfigService.warningstoAPIResponsewithField(default_factory=list).success=True, since it represents successful completion of the load operation while warnings communicate the fallback.The invalid configuration is no longer silently invisible to the user, while the existing fallback behavior remains unchanged.
Related Issue
Fixes # (issue number)
Type of Change
Checklist
Screenshots (if applicable)
Not applicable. The change affects CLI warnings and API response data rather than a graphical interface.