fix(config): synchronize API updates with the global runtime config - #100
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes configuration updates made through the API being applied only to a request-local
ConfigLoaderinstead of the process-wide configuration used by the application.ConfigService()now uses the global loader when no explicit config path is supplied. Updates, resets, and loads mutate the shared configuration object in place, preserving object identity for runtime consumers. Services constructed with an explicitconfig_pathremain isolated for CLI and test use cases.The change also validates candidate configuration values before applying them, documents runtime versus startup-only settings, and adds regression coverage for API-key revocation and global synchronization.
Related Issue
Fixes the confirmed configuration runtime synchronization bug.
Type of Change
Checklist
Validation
uv run pytest -q— 1548 passed, 2 skippeduv run ruff check .— passeduv run ruff format . --check— passeduv run pyright— 0 errorsuv run pre-commit run --all-files— code-quality hooks passed; the existing Prettier failure affects unrelated historical Markdown/YAML files and was reproduced from a cleanHEAD.Screenshots (if applicable)
Not applicable.