Printing Pyramid Patterns in Python#78
Open
wajeehacom wants to merge 1 commit intoGrow-with-Open-Source:mainfrom
Open
Printing Pyramid Patterns in Python#78wajeehacom wants to merge 1 commit intoGrow-with-Open-Source:mainfrom
wajeehacom wants to merge 1 commit intoGrow-with-Open-Source:mainfrom
Conversation
|
👋 @wajeehacom |
iamwatchdogs
requested changes
Mar 19, 2026
Contributor
iamwatchdogs
left a comment
There was a problem hiding this comment.
Hi @wajeehacom, please review the change requests and make the necessary changes to proceed.
Comment on lines
+2
to
+11
| def full_pyramid(n): | ||
| for i in range(1, n + 1): | ||
| # Print leading spaces | ||
| for j in range(n - i): | ||
| print(" ", end="") | ||
|
|
||
| # Print asterisks for the current row | ||
| for k in range(1, 2*i): | ||
| print("*", end="") | ||
| print() |
Contributor
There was a problem hiding this comment.
Make use of Pythonic features to write more effective & clean code.
Suggested change
| def full_pyramid(n): | |
| for i in range(1, n + 1): | |
| # Print leading spaces | |
| for j in range(n - i): | |
| print(" ", end="") | |
| # Print asterisks for the current row | |
| for k in range(1, 2*i): | |
| print("*", end="") | |
| print() | |
| def full_pyramid(n): | |
| for i in range(1, n + 1): | |
| # Print leading spaces | |
| print(" " * (n - i), end="") | |
| # Print asterisks for the current row | |
| print("*" * (2*i-1)) |
Tip
Just for educational purposes, here's an oneliner version:
(lambda n : print('\n'.join([ f'{" " * (n-i)}{"*" * (2*i-1)}' for i in range(1, n+1) ])))(int(input('Size of triangle: ')))| print("*", end="") | ||
| print() | ||
|
|
||
| full_pyramid(5) No newline at end of file |
Contributor
There was a problem hiding this comment.
Make a habit of using name-main idiom, even though it feels like it won't make much difference in scripts like this one.
Suggested change
| full_pyramid(5) | |
| if __name__ == "__main__": | |
| full_pyramid(5) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a Python program that prints a pyramid pattern based on user input. The program demonstrates nested loops and formatting techniques.
Changes made
pyramid_pattern.pyin the branchfeature/pyramid-pattern.