Note Widget Fixes - #36
Open
prestoncraw wants to merge 3 commits into
Open
Conversation
prestoncraw
marked this pull request as draft
August 6, 2026 20:16
prestoncraw
marked this pull request as ready for review
August 6, 2026 20:52
prestoncraw
force-pushed
the
NoteWindow_ExcessiveCalls
branch
from
August 6, 2026 20:52
ce0e518 to
4415d6a
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the Notes widget to use server-side pagination and filtering for note results, and adds permission-aware note deletion with confirmation, improving scalability and UX for large note sets.
Changes:
- Switched note loading from
GetAllto paged queries (SearchPage) and added page-count retrieval (GetPageInfo). - Moved selected note-tag filtering to the server and reset paging when key context changes (record/reference/tags).
- Added delete capability gated by authorization, with a confirmation prompt and refresh after deletion.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| TSX/Widget/NoteWindow/NoteWindow.tsx | Implements server-side paging/filtering, page-info tracking, and deletion workflow wiring. |
| TSX/Widget/NoteWindow/NoteTable.tsx | Adds delete UI (trash button + confirmation modal) and passes deletion callbacks/state. |
Suppressed comments (1)
TSX/Widget/NoteWindow/NoteWindow.tsx:230
- When metadata is loading/errored, notes are cleared but noteStatus is not reset. If noteStatus is currently 'loading' or 'error' from a prior request, the UI can keep showing a spinner or the "fetching note data" error while metadata is (re)loading for a different record/event.
if (metadataLoading || metadataError) {
setNotes([]);
return;
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
elwills
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Depends On