Visualization improvements for welcome page widgets. - #26973
Draft
linuspahl wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
This PR contains a collection of improvements for visualization widgets. These have been implemented for the visualzation widgets added to the welcome page with #26961.
Included changes:
Before
After
Allow defining custom default chart colors via React context. Necessary to define different chart colors for area visualization on welcome page, where we don't know the sources used for the traces, upfront.
Allow defining custom widget actions via React context, instead of using default view actions from
views.widgets.actionsplugin. Necessary to display custom replay search actions for alerts and events widget on welcome page./nocl - small visual change