-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add guide lines feature #3644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jsjgdh
wants to merge
26
commits into
GraphiteEditor:master
Choose a base branch
from
jsjgdh:new_branch5
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add guide lines feature #3644
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
390febb
Added guide lines feature with ruler drag interaction
jsjgdh 9e95d01
Fixed Guide Movement
jsjgdh 30cf143
Added cursor handling for guide dragging
jsjgdh 2b9e692
Removed unneccessary code
jsjgdh 5f1d410
Test
jsjgdh ca8ec23
Fix guide rotation alignment
jsjgdh 49561a8
Fix guide alignment in case of rotated artboard
jsjgdh 9ac6f79
Fixed offset
jsjgdh 4cf39f8
Color change
jsjgdh df1672a
Update editor/src/messages/portfolio/document/overlays/guide_overlays.rs
jsjgdh 5cb66eb
Update editor/src/messages/portfolio/document/overlays/guide_overlays.rs
jsjgdh 571ce0d
Changes as per recommendation
jsjgdh edd35a0
remove unnecessary code
jsjgdh 2aa267e
Name change
jsjgdh 32754ff
Fix merge conflicts
jsjgdh d1c3863
Fix GuideLine message derive macro attribute and Svelte runtime TypeE…
jsjgdh 3e8a8ba
Expose guide line commands via editor_commands macro to EditorWrapper
jsjgdh c8c1b85
format
jsjgdh fdc6152
removed unused import
jsjgdh b81b5ba
Address AI review feedback
jsjgdh dc2c9ec
Fix isGuideEditor type guard and add onDestroy drag cleanup
jsjgdh 522ad4d
Snapping
jsjgdh 1db5c3c
Ai-Review
jsjgdh e5731fe
Fix AI review feedback
jsjgdh 163eb65
Fix AI review feedback
jsjgdh 0b4721e
Fix typescript-eslint type assertion error in isGuideEditor
jsjgdh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.