Make the Pen tool close a path by double-clicking#3311
Make the Pen tool close a path by double-clicking#3311krVatsal wants to merge 23 commits intoGraphiteEditor:masterfrom
Conversation
Signed-off-by: krVatsal <kumarvatsal34@gmail.com>
|
!build |
|
|
Do i need to do something in order to get this pr reviewed? |
|
No, everything fine we're just a bit behind on PRs, situation will improve when Keavon is back from vacation. Thanks for contributing :) |
|
Sure, thanks! |
|
!build |
|
Fails to compile now. |
timon-schelling
force-pushed
the
master
branch
from
124235a to
a42cad8
Compare
The conflicts are resolved , can you review this one also. |
|
!build |
Signed-off-by: krVatsal <kumarvatsal34@gmail.com>
|
!build |
|
2026-01-13.18-10-26.mp4Doesn't seem to work as expected. |
|
Can you clarify what is the desired output, drawing should end without closing the path or it should close the the shape on double click? |
|
Closing the path, see the issue you linked. |
Signed-off-by: krVatsal <kumarvatsal34@gmail.com>
Can you review it now? |
|
!build |
|
timon-schelling
changed the title
|
LGTM, @0HyperCube any comments? |
0HyperCube
left a comment
0HyperCube
left a comment
There was a problem hiding this comment.
Seems good.
I guess you could have bound an event for DoubleClick in the input_mappings.rs but that would confuse the logic since it happens only on mouse up.
Keavon
changed the title
|
Yeah, from a behavioral perspective, this needs to not close the path upon releasing the mouse from a fast click-click-drag (double-clicking the mouse down part, but dragging during the second mouse down). Currently, that scenario results in unexpected behavior after mouse up. |
|
!build |
|
|
This doesn't work as expected in the following case: capture_16_.mp4If there is clearly a single endpoint on the path being drawn, it should use that, not the starting point for the current drawing session. But if it attempts to find the endpoint but there is no single unambiguous one, because a vector mesh is involved in the currently-being-drawn subpath, then it should use the current behavior, for example this is correct: capture_17_.mp4 |
|
Got it, will improve this. |
|
I'd like it so if you accidentally double-click, you can hit Ctrl+Z and return to the drawing state you were in immediately before you double-clicked. This already works for regular segment drawing, where you can hit Ctrl+Z to undo each segment and continue where you were immediately before drawing each segment, still interactively placing the next segment. That's how we'd like to work after double-clicking and hitting Ctrl+Z. |
…ool' of https://github.com/krVatsal/Graphite into add-feature-to-stop-drawing-on-double-click-using-pen-tool
|
Should it behave like: when we hit Ctrl+Z(after closing path) then we can continue drawing without clicking again on the last node? If it is so, then if we keep hitting Ctrl+Z again and again it should be able to continue drawing without clicking again on the last node, which is not the current situation with pen tool after a certain number of undos. Is this a desired condition to reduce overhead or a bug? Recording.2026-02-18.193421.1.mp4 |
|
You've encountered the same bug I noticed a couple of times, but was not able to reproduce reliably. If you can help debug that and solve it also, that would be really helpful. It doesn't have to be part of this PR. |
Sure i will open a new issue for this bug. |
4 participants
Closes the active pen path when the user intentionally double-clicks.
Closes #3219