Move the math expression parser from Pest to Chumsky and add more features#2685
Merged
Conversation
Keavon
changed the title
Keavon
changed the title
Keavon
marked this pull request as draft
June 14, 2025 22:14
Keavon
force-pushed
the
master
branch
2 times, most recently
from
June 20, 2025 06:47
34dced3 to
5cacab2
Compare
Member
|
I have rebased this branch to remove merge commits, so you'll need to |
Keavon
force-pushed
the
master
branch
2 times, most recently
from
June 28, 2025 13:25
316a737 to
532e913
Compare
Keavon
force-pushed
the
master
branch
4 times, most recently
from
July 10, 2025 05:48
ec51271 to
e025103
Compare
|
How far is this? I might be interested in implementing some math expressions from #2026 |
Contributor
Author
Its ready for review, its just not being merged becuase without variadics of some form this node is pretty useless, creating the custom error message for the node is also a difficult task. |
timon-schelling
force-pushed
the
master
branch
from
January 6, 2026 03:38
124235a to
a42cad8
Compare
Keavon
force-pushed
the
master
branch
4 times, most recently
from
March 11, 2026 12:15
3697b7d to
90533e6
Compare
Keavon
marked this pull request as ready for review
March 16, 2026 21:32
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 14 files
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Keavon
force-pushed
the
master
branch
3 times, most recently
from
March 17, 2026 00:10
e58c1de to
df8001f
Compare
Keavon
force-pushed
the
master
branch
4 times, most recently
from
March 19, 2026 11:00
9b97ab7 to
2e842cb
Compare
Contributor
|
All the AI reviews are mostly valid. |
Contributor
|
There are some unused imports too. |
Keavon
force-pushed
the
master
branch
2 times, most recently
from
April 29, 2026 12:16
f07c79b to
76938eb
Compare
Keavon
force-pushed
the
master
branch
2 times, most recently
from
May 17, 2026 14:37
4b7a823 to
847b8e9
Compare
timon-schelling
force-pushed
the
master
branch
2 times, most recently
from
May 17, 2026 15:37
15fcaac to
d5f0140
Compare
Keavon
force-pushed
the
Math
branch
2 times, most recently
from
July 16, 2026 02:34
c2f0c11 to
b1c49fe
Compare
…r, adding functions, comparisons, logic, and conditionals
Member
|
!build (Run ID 30219912385) |
Wasm: 36.28 MB — JS: 0.44 MB — CSS: 0.09 MB — Fonts: 0.30 MB — Images: 0.09 MB — All Assets: 37.21 MB |
Keavon
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2026
Switches to the chumsky parser for performance, remove Unit support until #586 is resolved.
Improves parser performance by about 40%, while also reducing compile times and improving readability.