Repository navigation
Updated pipeline for vulnerability checking to release gate on failin… - #46
Open
andreimerlescu wants to merge 1 commit into
Open
andreimerlescu wants to merge 1 commit into
andreimerlescu wants to merge 1 commit into
Conversation
…g RUSTSEC noticies until they are patched Signed-off-by: Andrei Merlescu <andrei+github@merlescu.net>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Moves RustSec advisories out of the
licencesjob into a newvulnerabilitiesworkflow that ranks each one by severity and decides pass, warn or fail. An
unfixed upstream advisory no longer blocks unrelated work, and a fixable one
still has to be fixed before a release.
Until now advisories gated only
graphicle-graph(the memory library and theprogram were checked for licences only),
release.ymlchecked none, and everyadvisory failed every pull request alike, whatever its severity and whether a
fix existed.
licencesjob:cargo deny check bans licenses sourcesfor all three crates..github/workflows/vulnerabilities.yml, per crate, on pull requests, pushesto main, daily, and from
release.ymlbefore it publishes.packaging/advisory_gate.pyranks findings by CVSS, or by RustSec categorywhen there is no score (471 of 985 RustSec vulnerabilities have none):
.github/advisories.toml: advisories the maintainers accept, each with areason and a
review_bydate; still reported, and unreviewed again afterthat date.
After merging: make
vulnerabilities (graphicle),(graphicle-graph)and(graphicle-memory)required checks. Bumping libz-sys to 1.1.33 (separate PR)clears the one failure this check finds on main (RUSTSEC-2026-0544).
How you tested it
python3 packaging/test_advisory_gate.py: 12 tests (CVSS 3.1 referencescores, each mode's decisions, acceptance expiry, policy validation). The
workflow runs them too.
python3 packaging/advisory_gate.py --crate crates/graphicle-memory --mode mainwith cargo-deny 0.20.2 on main: fails on RUSTSEC-2026-0544 (libz-sys, fix
available), warns on chrono and chrono-tz. With
--mode pr --base HEAD:passes with warnings.
cargo deny check bans licenses sourcespasses in all three crates.actionlintnot run yet.Checklist
git commit -s), as theDeveloper Certificate of Origin asks
(CONTRIBUTING.md).
described in the workflow's header and in
.github/advisories.toml;CONTRIBUTING.md is unchanged.)
Cargo.lockchanged, I rancargo deny checkin that crate andrefreshed its licence page, as CONTRIBUTING.md describes. (No lockfile
changes.)
credited in the crate's
NOTICE.md. (None taken.)evidence in
docs/benchmarks.md. (No benchmark or docs claims changed.)