Skip to content

Updated pipeline for vulnerability checking to release gate on failin… - #46

Open
andreimerlescu wants to merge 1 commit into
Graphicle-AI:mainfrom
andreimerlescu:vulnerability-check
Open

andreimerlescu wants to merge 1 commit into
Graphicle-AI:mainfrom
andreimerlescu:vulnerability-check

Conversation

@andreimerlescu

Copy link
Copy Markdown
Contributor

What this changes

Moves RustSec advisories out of the licences job into a new vulnerabilities
workflow that ranks each one by severity and decides pass, warn or fail. An
unfixed upstream advisory no longer blocks unrelated work, and a fixable one
still has to be fixed before a release.

Until now advisories gated only graphicle-graph (the memory library and the
program were checked for licences only), release.yml checked none, and every
advisory failed every pull request alike, whatever its severity and whether a
fix existed.

  • licences job: cargo deny check bans licenses sources for all three crates.
  • .github/workflows/vulnerabilities.yml, per crate, on pull requests, pushes
    to main, daily, and from release.yml before it publishes.
    packaging/advisory_gate.py ranks findings by CVSS, or by RustSec category
    when there is no score (471 of 985 RustSec vulnerabilities have none):
Pull request main, daily Release
High/critical, fix exists fails only if the PR brings it in fails fails
High/critical, no fix fails only if the PR brings it in warns fails unless accepted
Medium / low warns / notice warns / notice warns / notice
Unmaintained, unsound, yanked warns warns warns
  • .github/advisories.toml: advisories the maintainers accept, each with a
    reason and a review_by date; still reported, and unreviewed again after
    that date.

After merging: make vulnerabilities (graphicle), (graphicle-graph) and
(graphicle-memory) required checks. Bumping libz-sys to 1.1.33 (separate PR)
clears the one failure this check finds on main (RUSTSEC-2026-0544).

How you tested it

  • python3 packaging/test_advisory_gate.py: 12 tests (CVSS 3.1 reference
    scores, each mode's decisions, acceptance expiry, policy validation). The
    workflow runs them too.
  • python3 packaging/advisory_gate.py --crate crates/graphicle-memory --mode main
    with cargo-deny 0.20.2 on main: fails on RUSTSEC-2026-0544 (libz-sys, fix
    available), warns on chrono and chrono-tz. With --mode pr --base HEAD:
    passes with warnings.
  • cargo deny check bans licenses sources passes in all three crates.
  • The three workflow files parse as YAML; actionlint not run yet.

Checklist

  • Every commit is signed off (git commit -s), as the
    Developer Certificate of Origin asks
    (CONTRIBUTING.md).
  • Tests and docs are updated where the behaviour changed. (The policy is
    described in the workflow's header and in .github/advisories.toml;
    CONTRIBUTING.md is unchanged.)
  • If a Cargo.lock changed, I ran cargo deny check in that crate and
    refreshed its licence page, as CONTRIBUTING.md describes. (No lockfile
    changes.)
  • Code taken or ported from another project is permissively licensed and
    credited in the crate's NOTICE.md. (None taken.)
  • If I changed a benchmark number or a claim in the docs, it links to its
    evidence in docs/benchmarks.md. (No benchmark or docs claims changed.)

…g RUSTSEC noticies until they are patched

Signed-off-by: Andrei Merlescu <andrei+github@merlescu.net>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant