Decompose CamConfig into data, domain and UI layers - #707
Open
m4pl wants to merge 25 commits into
Open
Conversation
m4pl
changed the title
Author
|
Waiting for the PR merge. |
thestinger
force-pushed
the
compose-prototype
branch
2 times, most recently
from
September 8, 2026 20:58
e07f57c to
779bc8b
Compare
m4pl
force-pushed
the
task/704-decompose-cam-config
branch
from
September 9, 2026 08:31
c9f6e07 to
8d36ce3
Compare
m4pl
force-pushed
the
task/704-decompose-cam-config
branch
from
September 9, 2026 08:33
8d36ce3 to
f255a48
Compare
m4pl
marked this pull request as ready for review
September 9, 2026 10:33
m4pl
force-pushed
the
task/704-decompose-cam-config
branch
from
September 9, 2026 13:00
3ddaaef to
785cdc8
Compare
RankoR
suggested changes
Sep 9, 2026
| import app.grapheneos.camera.data.camera.model.ExtensionKey | ||
| import app.grapheneos.camera.data.camera.repository.CameraProviderSource | ||
| import app.grapheneos.camera.data.camera.repository.ExtensionAvailabilityRepository | ||
| import app.grapheneos.camera.domain.camera.mapper.VideoQualityFeatureMapper |
| import kotlin.concurrent.thread | ||
|
|
||
| @SuppressLint("UnsafeOptInUsageError") | ||
| class CameraSession @AssistedInject constructor( |
Contributor
There was a problem hiding this comment.
Final class with no interface -> can't be properly mocked.
sdsantos
approved these changes
Sep 10, 2026
|
|
||
| MaterialAlertDialogBuilder(activity) | ||
| .setTitle(R.string.more_options) | ||
| .setMultiChoiceItems(optionNames.toTypedArray(), values) { _, index, isChecked -> |
There was a problem hiding this comment.
Does not have to be in this PR, but we should eventually give proper names to these formats, like UPC-A instead of UPC_A.
Author
There was a problem hiding this comment.
I think we can do that when we rewrite it in Compose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #704
Splits
CamConfiginto aCameraSession, camera use cases and aViewfinderController, so nothing below the UI holds an Activity.