use TaskChampion Task when creating/setting setting status - #4157
Open
carmiac wants to merge 1 commit into
Open
Conversation
djmitche
reviewed
Aug 1, 2026
djmitche
left a comment
djmitche
left a comment
Collaborator
There was a problem hiding this comment.
This looks good - just some minor suggestions. And as always I'm sorry for getting to it so late.
| const std::unordered_map<std::string, size_t>&); | ||
|
|
||
| //////////////////////////////////////////////////////////////////////////////// | ||
| // Map the C++ on-disk status string to the typed `tc::Status` enum used by the |
Collaborator
There was a problem hiding this comment.
Suggested change
| // Map the C++ on-disk status string to the typed `tc::Status` enum used by the | |
| // Map the C++ representation of status to the typed `tc::Status` enum used by the |
Comment on lines
+156
to
+157
| std::string deferred_status; | ||
| bool deferred_status_changed = false; |
Collaborator
There was a problem hiding this comment.
You could use std::optional<std::string> here instead of two variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part 3 of the split of #4113