Repository navigation
Conversation
product-auto-label
Bot
added
the
samples
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Gemini model version from 'gemini-3.5-flash' to 'gemini-3.8-flash' across several example scripts, including controlled generation, token counting, chat, and text generation. It also upgrades the 'google-genai' package dependency to version 2.29.0 in the tools requirements, changes the 'GOOGLE_CLOUD_LOCATION' environment variable to 'global' in the test suite, and removes the 'temperature' configuration from the function definition tool example. There are no review comments, and I have no feedback to provide.
…d temperature=0 Update five Google GenAI SDK samples (`ctrlgen_with_class_schema.py`, `counttoken_with_txt.py`, `textgen_chat_with_txt.py`, `textgen_with_txt.py`, and `tools_func_def_with_txt.py`) to use the latest `gemini-3.8-flash` model. In `genai/tools/tools_func_def_with_txt.py`, remove `temperature=0` from `GenerateContentConfig`, as setting temperature below 1.0 is deprecated for Gemini 3.x models. Also update `genai/tools/test_tools_examples.py` to use `GOOGLE_CLOUD_LOCATION = "global"` and `genai/tools/requirements.txt` to `google-genai==2.29.0` for consistency with the other `genai/` test suites.
iennae
force-pushed
the
fix/genai-gemini-3-8-flash
branch
from
October 24, 2026 17:51
d87195b to
00af603
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
genai/samples (ctrlgen_with_class_schema.py,counttoken_with_txt.py,textgen_chat_with_txt.py,textgen_with_txt.py, andtools_func_def_with_txt.py) to the latestgemini-3.8-flashmodel.temperature=0fromGenerateContentConfigingenai/tools/tools_func_def_with_txt.py.genai/tools/test_tools_examples.py(GOOGLE_CLOUD_LOCATION = "global") andgenai/tools/requirements.txt(google-genai==2.29.0) with the othergenai/test suites.