chore(deps): update dependency isort to v8#13845
chore(deps): update dependency isort to v8#13845renovate-bot wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the update of the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request updates isort to version 8.0.0. However, this version is incompatible with Python versions older than 3.10. The current changes attempt to install isort 8.0.0 on Python 3.8 and below, which will cause installation failures because isort 6.0.0 dropped support for Python 3.8 and isort 7.0.0 dropped support for Python 3.9. I have suggested adjusting the environment markers to ensure compatible versions are used for older Python runtimes while adopting the latest version for modern environments.
| isort==8.0.0; python_version > "3.9" | ||
| isort==8.0.0; python_version <= "3.8" |
There was a problem hiding this comment.
Updating isort to 8.0.0 for Python versions 3.8 and below is incorrect. According to the release notes, isort 6.0.0 dropped support for Python 3.8, and isort 7.0.0 dropped support for Python 3.9. Version 8.0.0 requires Python 3.10 or higher. Attempting to install 8.0.0 on Python 3.8 will result in a pip installation error due to python_requires incompatibility.
Additionally, the previous configuration appeared to have a gap for Python 3.9. I recommend explicitly defining versions for each supported Python range.
isort==8.0.0; python_version >= "3.10"
isort==6.0.0; python_version == "3.9"
isort==5.13.2; python_version <= "3.8"
This PR contains the following updates:
==5.13.2→==8.0.0==6.0.0→==8.0.0Release Notes
PyCQA/isort (isort)
v8.0.0Compare Source
--old-findersand--magic-placementflags andold_findersconfiguration option. The legacy finder logic that relied on environment introspection has been removed (#2445) @joao-faria-devploneprofile to not clash withblack(#2456) @ale-rtv7.0.0Compare Source
Changes
💥 Breaking Changes
🚀 Features
🪲 Fixes
3.14and fix any bugs (#2425) @DanielNoord👷 Continuous Integration
ruffinstead ofblack(#2432) @DanielNoordruff(#2431) @DanielNoord📦 Dependencies
v6.1.0Compare Source
v6.0.1Compare Source
v6.0.0Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.