Skip to content

Comments

chore(deps): update dependency isort to v8#13845

Open
renovate-bot wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
renovate-bot:renovate/isort-8.x
Open

chore(deps): update dependency isort to v8#13845
renovate-bot wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
renovate-bot:renovate/isort-8.x

Conversation

@renovate-bot
Copy link
Contributor

This PR contains the following updates:

Package Change Age Confidence
isort (changelog) ==5.13.2==8.0.0 age confidence
isort (changelog) ==6.0.0==8.0.0 age confidence

Release Notes

PyCQA/isort (isort)

v8.0.0

Compare Source

  • Removed --old-finders and --magic-placement flags and old_finders configuration option. The legacy finder logic that relied on environment introspection has been removed (#​2445) @​joao-faria-dev

v7.0.0

Compare Source

Changes

💥 Breaking Changes

🚀 Features

🪲 Fixes

👷 Continuous Integration

📦 Dependencies

v6.1.0

Compare Source

v6.0.1

Compare Source

v6.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate-bot renovate-bot requested review from a team as code owners February 19, 2026 18:29
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: compute Issues related to the Compute Engine API. labels Feb 19, 2026
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 19, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automates the update of the isort dependency to version 8.0.0 within the compute/client_library/requirements.txt file. This update aims to keep the project's dependencies current, incorporating the latest features and bug fixes from isort. However, it introduces significant changes, including potential breaking changes related to Python version support and removed command-line options, which warrant careful review to ensure continued compatibility and functionality.

Highlights

  • Dependency Update: The isort dependency has been updated to its latest major version, v8.0.0, across all specified Python environments in compute/client_library/requirements.txt.
  • Potential Python Version Incompatibility: While isort v6.0.0 dropped support for Python 3.8 and v7.0.0 dropped support for Python 3.9, this update specifies isort==8.0.0 for python_version <= "3.8". This may lead to compatibility issues or runtime errors for projects targeting older Python environments.
  • Breaking Changes in isort v8.0.0: The isort v8.0.0 release removed the --old-finders and --magic-placement flags, which might require adjustments if these flags were previously used in project configurations.
Changelog
  • compute/client_library/requirements.txt
    • Updated isort from 6.0.0 to 8.0.0 for Python versions greater than 3.9.
    • Updated isort from 5.13.2 to 8.0.0 for Python versions less than or equal to 3.8.
Activity
  • This pull request was automatically generated by renovate-bot to update the isort dependency.
  • The PR description includes detailed release notes for isort versions 6.0.0, 6.0.1, 6.1.0, 7.0.0, and 8.0.0.
  • Automerge is currently disabled, requiring manual review and merging.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates isort to version 8.0.0. However, this version is incompatible with Python versions older than 3.10. The current changes attempt to install isort 8.0.0 on Python 3.8 and below, which will cause installation failures because isort 6.0.0 dropped support for Python 3.8 and isort 7.0.0 dropped support for Python 3.9. I have suggested adjusting the environment markers to ensure compatible versions are used for older Python runtimes while adopting the latest version for modern environments.

Comment on lines +1 to +2
isort==8.0.0; python_version > "3.9"
isort==8.0.0; python_version <= "3.8"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Updating isort to 8.0.0 for Python versions 3.8 and below is incorrect. According to the release notes, isort 6.0.0 dropped support for Python 3.8, and isort 7.0.0 dropped support for Python 3.9. Version 8.0.0 requires Python 3.10 or higher. Attempting to install 8.0.0 on Python 3.8 will result in a pip installation error due to python_requires incompatibility.

Additionally, the previous configuration appeared to have a gap for Python 3.9. I recommend explicitly defining versions for each supported Python range.

isort==8.0.0; python_version >= "3.10"
isort==6.0.0; python_version == "3.9"
isort==5.13.2; python_version <= "3.8"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: compute Issues related to the Compute Engine API. owlbot:run Add this label to trigger the Owlbot post processor. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants