Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion background/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"@google-cloud/functions": "^3.0.0",
"mocha": "^9.0.0",
"node-fetch": "^2.6.0",
"uuid": "^9.0.0",
"uuid": "^11.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Updating uuid to v11 drops support for Node.js versions earlier than 16. This conflicts with the engines requirement of node: >=12.0.0 specified in other modules of this repository (e.g., authenticating-users/package.json and bookshelf/package.json). This update will break compatibility for users on Node.js 12 or 14. Additionally, v11 introduces breaking changes to the v1 API. To resolve this, the repository's minimum Node.js version should be bumped to 16, or a compatible fix should be identified.

"wait-on": "^7.0.0"
}
}
2 changes: 1 addition & 1 deletion gce/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
},
"devDependencies": {
"mocha": "^9.0.0",
"uuid": "^9.0.0",
"uuid": "^11.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Updating uuid to v11 in devDependencies requires Node.js 16+, which conflicts with the Node.js 12 support indicated in other parts of this repository. This will cause test failures in environments running older Node.js versions.

"chai": "^4.2.0",
"node-fetch": "^2.6.0"
}
Expand Down