chore(iam): update dependencies - #4442
Draft
angelcaamal wants to merge 2 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates dependencies in iam/deny/package.json, including upgrading @google-cloud/iam, c8, and chai. Feedback points out that upgrading chai to ^6.0.0 will break tests because Chai v5 and above are ESM-only, whereas this project is configured as CommonJS. It is recommended to revert chai to ^4.5.0 to maintain compatibility.
| "c8": "^10.0.0", | ||
| "chai": "^4.5.0", | ||
| "c8": "^12.0.0", | ||
| "chai": "^6.0.0", |
Contributor
There was a problem hiding this comment.
Chai v5 and above are ESM-only. Since this project is configured as CommonJS (using require and lacking "type": "module" in package.json), upgrading to chai v6 will cause tests to fail with ERR_REQUIRE_ESM errors. Please keep chai at ^4.5.0 to maintain CommonJS compatibility.
Suggested change
| "chai": "^6.0.0", | |
| "chai": "^4.5.0", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes Internal: b/556287655
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.