feat(retail): add searchOffset, searchPagination, and searchRequest samples#4285
Open
angelcaamal wants to merge 4 commits intoGoogleCloudPlatform:mainfrom
Open
feat(retail): add searchOffset, searchPagination, and searchRequest samples#4285angelcaamal wants to merge 4 commits intoGoogleCloudPlatform:mainfrom
angelcaamal wants to merge 4 commits intoGoogleCloudPlatform:mainfrom
Conversation
…amples This commit introduces new Node.js code samples for Vertex AI Search, including comprehensive Mocha tests and logic to handle root-level product IDs and async indexing.
|
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces Node.js snippets for Google Cloud Retail search features, including offset-based search, paginated search, and general search requests, along with a comprehensive test suite. The review feedback highlights opportunities to improve test robustness against existing data, ensure consistency across snippets by adding missing strict mode directives, and standardize logging and error handling patterns.
Standardized catch block messages and updated console.error to use comma-separated arguments with error.message || error for better visibility.
Introduced a 30-second delay after test product creation using timers/promises. This allows the Google Cloud Retail search indexes enough time to build, preventing flaky test failures caused by eventual consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes Internal: b/502273843
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.