Skip to content

Build CI orchestration from the trusted base checkout - #18905

Open
roshanasingh4 wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
roshanasingh4:security/use-trusted-ci-binary
Open

Build CI orchestration from the trusted base checkout#18905
roshanasingh4 wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
roshanasingh4:security/use-trusted-ci-binary

Conversation

@roshanasingh4

@roshanasingh4 roshanasingh4 commented Sep 5, 2026

Copy link
Copy Markdown

Summary

The presubmit workflow currently merges proposed changes before building .ci/magician. Later build steps execute that binary while receiving Secret Manager-backed environment variables. As a result, changes to CI helper code in a pull request can replace the orchestration binary used by those steps.

This change:

  • builds the Magician binary from the base branch before merging proposed changes
  • preserves that pre-merge binary and launcher in a separate path
  • uses the preserved launcher for subsequent generation and test steps

The proposed repository changes are still merged and tested as before; this only changes which version of the CI orchestration binary controls those steps.

Testing

  • go test ./... in .ci/magician
  • parsed the Cloud Build YAML and verified all 16 secret-bearing steps use the preserved launcher
  • git diff --check

Release Note Template for Downstream PRs (will be copied)

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Sep 5, 2026
@github-actions
github-actions Bot requested a review from melinath September 5, 2026 16:12
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants