Build CI orchestration from the trusted base checkout - #18905
Open
roshanasingh4 wants to merge 2 commits into
Open
Build CI orchestration from the trusted base checkout#18905roshanasingh4 wants to merge 2 commits into
roshanasingh4 wants to merge 2 commits into
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The presubmit workflow currently merges proposed changes before building
.ci/magician. Later build steps execute that binary while receiving Secret Manager-backed environment variables. As a result, changes to CI helper code in a pull request can replace the orchestration binary used by those steps.This change:
The proposed repository changes are still merged and tested as before; this only changes which version of the CI orchestration binary controls those steps.
Testing
go test ./...in.ci/magiciangit diff --checkRelease Note Template for Downstream PRs (will be copied)