Skip to content

Acm ingress policy update fixes - #18903

Open
melinath wants to merge 7 commits into
GoogleCloudPlatform:mainfrom
melinath:acm-ingress-policy-update
Open

Acm ingress policy update fixes#18903
melinath wants to merge 7 commits into
GoogleCloudPlatform:mainfrom
melinath:acm-ingress-policy-update

Conversation

@melinath

@melinath melinath commented Sep 4, 2026

Copy link
Copy Markdown
Member

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

accesscontextmanager: added `etag` field to `google_access_context_manager_service_perimeter`
accesscontextmanager: fixed sending of `etag` on update requests for `google_access_context_manager_service_perimeter_egress_policy` and `google_access_context_manager_service_perimeter_ingress_policy` to prevent concurrent requests from impacting each other
accesscontextmanager: fixed bug in `google_access_context_manager_service_perimeter` where changes to the status / spec fields could cause updates to related ingress/egress policies even if those fields weren't specified on `google_access_context_manager_service_perimeter`

@melinath melinath changed the title Acm ingress policy update Acm ingress policy update fixes Sep 4, 2026
@modular-magician

modular-magician commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit f915f35:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 9 files changed, 157 insertions(+), 209 deletions(-)
google-beta provider View Diff 9 files changed, 157 insertions(+), 209 deletions(-)
terraform-google-conversion View Diff 1 file changed, 10 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
3 2 0 1
Affected Service Packages
  • accesscontextmanager

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccAccessContextManager

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log - TestAccAccessContextManager/access_level
✅ Log - TestAccAccessContextManager/access_level_condition
✅ Log - TestAccAccessContextManager/access_level_custom
✅ Log - TestAccAccessContextManager/access_level_full
✅ Log - TestAccAccessContextManager/access_levels
✅ Log - TestAccAccessContextManager/access_policy
✅ Log - TestAccAccessContextManager/authorized_orgs_desc
✅ Log - TestAccAccessContextManager/data_source_access_policy_basic
✅ Log - TestAccAccessContextManager/gcp_user_access_binding_principal
✅ Log - TestAccAccessContextManager/service_perimeter
✅ Log - TestAccAccessContextManager/service_perimeter_dry_run_egress_policy_update
✅ Log - TestAccAccessContextManager/service_perimeter_dry_run_ingress_policy_update
✅ Log - TestAccAccessContextManager/service_perimeter_dry_run_resource
✅ Log - TestAccAccessContextManager/service_perimeter_egress_policy_update
✅ Log - TestAccAccessContextManager/service_perimeter_ingress_policy_update
✅ Log - TestAccAccessContextManager/service_perimeter_nongcp_patterns
✅ Log - TestAccAccessContextManager/service_perimeter_resource
✅ Log - TestAccAccessContextManager/service_perimeter_update
✅ Log - TestAccAccessContextManager/service_perimeters
✅ Log - TestAccAccessContextManager/service_perimeters_nongcp_patterns
❌ Error · Log - TestAccAccessContextManager/gcp_user_access_binding
❌ Error · Log - TestAccAccessContextManager/service_perimeter_dry_run_egress_policy
❌ Error · Log - TestAccAccessContextManager/service_perimeter_dry_run_ingress_policy
❌ Error · Log - TestAccAccessContextManager/service_perimeter_egress_policy
❌ Error · Log - TestAccAccessContextManager/service_perimeter_ingress_policy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@melinath VCR tests complete for f915f35!

@modular-magician

modular-magician commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 940bc4a:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 6 files changed, 228 insertions(+), 25 deletions(-)
google-beta provider View Diff 6 files changed, 228 insertions(+), 25 deletions(-)
terraform-google-conversion View Diff 1 file changed, 10 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
3 2 0 1
Affected Service Packages
  • accesscontextmanager

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccAccessContextManager

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log - TestAccAccessContextManager/access_level
✅ Log - TestAccAccessContextManager/access_level_condition
✅ Log - TestAccAccessContextManager/access_level_custom
✅ Log - TestAccAccessContextManager/access_level_full
✅ Log - TestAccAccessContextManager/access_levels
✅ Log - TestAccAccessContextManager/access_policy
✅ Log - TestAccAccessContextManager/authorized_orgs_desc
✅ Log - TestAccAccessContextManager/data_source_access_policy_basic
✅ Log - TestAccAccessContextManager/gcp_user_access_binding_principal
✅ Log - TestAccAccessContextManager/service_perimeter
✅ Log - TestAccAccessContextManager/service_perimeter_dry_run_egress_policy
✅ Log - TestAccAccessContextManager/service_perimeter_dry_run_egress_policy_update
✅ Log - TestAccAccessContextManager/service_perimeter_dry_run_ingress_policy
✅ Log - TestAccAccessContextManager/service_perimeter_dry_run_ingress_policy_update
✅ Log - TestAccAccessContextManager/service_perimeter_dry_run_resource
✅ Log - TestAccAccessContextManager/service_perimeter_egress_policy
✅ Log - TestAccAccessContextManager/service_perimeter_egress_policy_update
✅ Log - TestAccAccessContextManager/service_perimeter_ingress_policy
✅ Log - TestAccAccessContextManager/service_perimeter_ingress_policy_update
✅ Log - TestAccAccessContextManager/service_perimeter_nongcp_patterns
✅ Log - TestAccAccessContextManager/service_perimeter_resource
✅ Log - TestAccAccessContextManager/service_perimeter_update
✅ Log - TestAccAccessContextManager/service_perimeters
✅ Log - TestAccAccessContextManager/service_perimeters_nongcp_patterns
❌ Error · Log - TestAccAccessContextManager/gcp_user_access_binding

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@melinath VCR tests complete for 940bc4a!

@modular-magician

modular-magician commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit de20a70:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 9 files changed, 363 insertions(+), 26 deletions(-)
google-beta provider View Diff 9 files changed, 363 insertions(+), 26 deletions(-)
terraform-google-conversion View Diff 1 file changed, 10 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
3 2 0 1
Affected Service Packages
  • accesscontextmanager

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccAccessContextManager

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log - TestAccAccessContextManager/access_level
✅ Log - TestAccAccessContextManager/access_level_condition
✅ Log - TestAccAccessContextManager/access_level_custom
✅ Log - TestAccAccessContextManager/access_level_full
✅ Log - TestAccAccessContextManager/access_levels
✅ Log - TestAccAccessContextManager/access_policy
✅ Log - TestAccAccessContextManager/authorized_orgs_desc
✅ Log - TestAccAccessContextManager/data_source_access_policy_basic
✅ Log - TestAccAccessContextManager/gcp_user_access_binding_principal
✅ Log - TestAccAccessContextManager/service_perimeter
✅ Log - TestAccAccessContextManager/service_perimeter_dry_run_egress_policy
✅ Log - TestAccAccessContextManager/service_perimeter_dry_run_egress_policy_update
✅ Log - TestAccAccessContextManager/service_perimeter_dry_run_ingress_policy
✅ Log - TestAccAccessContextManager/service_perimeter_dry_run_ingress_policy_update
✅ Log - TestAccAccessContextManager/service_perimeter_dry_run_resource
✅ Log - TestAccAccessContextManager/service_perimeter_egress_policy
✅ Log - TestAccAccessContextManager/service_perimeter_egress_policy_parent_update
✅ Log - TestAccAccessContextManager/service_perimeter_egress_policy_update
✅ Log - TestAccAccessContextManager/service_perimeter_ingress_policy
✅ Log - TestAccAccessContextManager/service_perimeter_ingress_policy_update
✅ Log - TestAccAccessContextManager/service_perimeter_nongcp_patterns
✅ Log - TestAccAccessContextManager/service_perimeter_resource
✅ Log - TestAccAccessContextManager/service_perimeter_update
✅ Log - TestAccAccessContextManager/service_perimeters
✅ Log - TestAccAccessContextManager/service_perimeters_nongcp_patterns
❌ Error · Log - TestAccAccessContextManager/gcp_user_access_binding

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@melinath VCR tests complete for de20a70!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants