Skip to content

ces: add extra_tool_call_behavior to google_ces_app - #18900

Open
slevenick wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
slevenick:mm-b-550549281
Open

ces: add extra_tool_call_behavior to google_ces_app#18900
slevenick wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
slevenick:mm-b-550549281

Conversation

@slevenick

Copy link
Copy Markdown
Contributor

Added field coverage for evaluationMetricsThresholds.goldenEvaluationMetricsThresholds.toolMatchingSettings.extraToolCallBehavior on google_ces_app (ces:v1:App).

reference: b/550549281

ces: added `evaluation_metrics_thresholds.golden_evaluation_metrics_thresholds.tool_matching_settings.extra_tool_call_behavior` field to `google_ces_app`

@modular-magician

modular-magician commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit eefbb38:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 8 files changed, 160 insertions(+)
google-beta provider View Diff 8 files changed, 160 insertions(+)
terraform-google-conversion View Diff 1 file changed, 33 insertions(+)
Open in Cloud Shell View Diff 1 file changed, 3 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
79 77 0 2
Affected Service Packages
  • ces

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccCESApp_cesAppBasicExample
  • TestAccCESApp_update

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccCESApp_cesAppBasicExample
✅ Log TestAccCESApp_update

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@slevenick VCR tests complete for eefbb38!

@slevenick

Copy link
Copy Markdown
Contributor Author

@modular-magician reassign-reviewer

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants