Batch Projects.Get requests for google_project_service

[joscha-alisch]

In the past, batching was introduced for service list requests in google_project_service to fix slow refreshes and prevent running into rate limiting. This already improved the situation a lot. However, there is still an additional request to Project.Get being made for every single google_project_service, to identify whether the containing project had been scheduled for deletion in the meantime.

I tested this with a project with ~100 services enabled. Without batching i could see the ~100 requests to list services, in addition to another ~100 requests to get the same project all over again. With batching enabled (and the necessary parallelism enabled), the requests to list services were all correctly batched to a single request. The ~100 Project.Get requests however stayed, effectively only realising half of the potential speed up that batching can achieve here.

This PR introduces request batching also for the Project.Get requests, bringing the number of requests for any number of google_project_service (on the same project) to a static 2 (if parallelism is sufficient).

Contributes to

• Reading many google_project_service is very slow. hashicorp/terraform-provider-google#11757
• Migrating to google_project_service from google_project_services = much slower hashicorp/terraform-provider-google#5266
• Swapping from "google_project_services" to "google_project_service" causes API rate limiting error hashicorp/terraform-provider-google#4689

Release Note Template for Downstream PRs (will be copied)

resourcemanager: reduced redudant `Projects.Get` API calls in `google_project_service` during refresh by batching them per project

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 499b110:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	3 files changed, 184 insertions(+), 16 deletions(-)
google-beta provider	View Diff	3 files changed, 184 insertions(+), 16 deletions(-)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
188	156	31	1

Affected Service Packages

• resourcemanager

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccProjectIamMemberRemove_memberInMultipleBindings

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccProjectIamMemberRemove_memberInMultipleBindings

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@joscha-alisch, @rileykarson VCR tests complete for 499b110!