Skip to content

Add Vertex AI RagCorpus resource - #18889

Open
BBBmau wants to merge 5 commits into
GoogleCloudPlatform:mainfrom
BBBmau:cmek-vertex-rag-engine
Open

Add Vertex AI RagCorpus resource#18889
BBBmau wants to merge 5 commits into
GoogleCloudPlatform:mainfrom
BBBmau:cmek-vertex-rag-engine

Conversation

@BBBmau

@BBBmau BBBmau commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Adds Magic Modules support for a new Vertex AI RAG corpus Terraform resource.

Summary:

  • Adds RagCorpus MMv1 schema for Vertex AI RAG Engine corpus creation, update, delete, import, and list-resource generation.
  • Exposes RAG-managed DB configuration, embedding model configuration, and CMEK via encryption_spec.kms_key_name.
  • Adds basic and CMEK-focused Terraform sample configs for generated acceptance test coverage.
`google_vertex_ai_rag_corpus`

@modular-magician

modular-magician commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 34e7721:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 8 files changed, 2268 insertions(+)
google-beta provider View Diff 8 files changed, 2268 insertions(+)
terraform-google-conversion View Diff 1 file changed, 361 insertions(+)
Open in Cloud Shell View Diff 8 files changed, 240 insertions(+)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_vertex_ai_rag_corpus

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
128 113 11 4
Affected Service Packages
  • vertexai

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated
  • TestAccVertexAIRagCorpusListQuery_generated
  • TestAccVertexAIRagCorpus_vertexAiRagCorpusBasicExample
  • TestAccVertexAIRagCorpus_vertexAiRagCorpusFullExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated
❌ Error · Log - TestAccVertexAIRagCorpusListQuery_generated
❌ Error · Log - TestAccVertexAIRagCorpus_vertexAiRagCorpusBasicExample
❌ Error · Log - TestAccVertexAIRagCorpus_vertexAiRagCorpusFullExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@BBBmau VCR tests complete for 34e7721!

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Sep 3, 2026
@modular-magician modular-magician added service/aiplatform-rag-engine and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Sep 3, 2026
@modular-magician

modular-magician commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 58126cd:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 8 files changed, 2268 insertions(+)
google-beta provider View Diff 8 files changed, 2268 insertions(+)
terraform-google-conversion View Diff 1 file changed, 361 insertions(+)
Open in Cloud Shell View Diff 8 files changed, 240 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
128 113 11 4
Affected Service Packages
  • vertexai

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated
  • TestAccVertexAIRagCorpusListQuery_generated
  • TestAccVertexAIRagCorpus_vertexAiRagCorpusBasicExample
  • TestAccVertexAIRagCorpus_vertexAiRagCorpusFullExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated
❌ Error · Log - TestAccVertexAIRagCorpusListQuery_generated
❌ Error · Log - TestAccVertexAIRagCorpus_vertexAiRagCorpusBasicExample
❌ Error · Log - TestAccVertexAIRagCorpus_vertexAiRagCorpusFullExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@BBBmau VCR tests complete for 58126cd!

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Sep 3, 2026
@modular-magician

modular-magician commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b1f485d:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 8 files changed, 2287 insertions(+)
google-beta provider View Diff 8 files changed, 2287 insertions(+)
terraform-google-conversion View Diff 1 file changed, 361 insertions(+)
Open in Cloud Shell View Diff 8 files changed, 249 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
128 113 11 4
Affected Service Packages
  • vertexai

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated
  • TestAccVertexAIRagCorpusListQuery_generated
  • TestAccVertexAIRagCorpus_vertexAiRagCorpusBasicExample
  • TestAccVertexAIRagCorpus_vertexAiRagCorpusFullExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccVertexAIRagCorpus_vertexAiRagCorpusBasicExample
✅ Log TestAccVertexAIRagCorpus_vertexAiRagCorpusFullExample
❌ Error · Log - TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated
❌ Error · Log - TestAccVertexAIRagCorpusListQuery_generated

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@BBBmau VCR tests complete for b1f485d!

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Sep 4, 2026
@modular-magician

modular-magician commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 9b0c60c:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 8 files changed, 2287 insertions(+)
google-beta provider View Diff 8 files changed, 2287 insertions(+)
terraform-google-conversion View Diff 1 file changed, 361 insertions(+)
Open in Cloud Shell View Diff 8 files changed, 249 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
128 115 11 2
Affected Service Packages
  • vertexai

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated
  • TestAccVertexAIRagCorpusListQuery_generated

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated
❌ Error · Log - TestAccVertexAIRagCorpusListQuery_generated

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@BBBmau VCR tests complete for 9b0c60c!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants