compute: add expose_host_topology to instance and instance template s… - #18882
compute: add expose_host_topology to instance and instance template s…#18882tanvinsharma wants to merge 1 commit into
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
658db96 to
d5fda65
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 658db96: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_instance" "primary" {
scheduling {
maintenance_interval = # value needed
}
}
Resource: resource "google_compute_instance_from_machine_image" "primary" {
scheduling {
availability_domain = # value needed
expose_host_topology = # value needed
maintenance_interval = # value needed
min_node_cpus = # value needed
}
}
Resource: resource "google_compute_instance_from_template" "primary" {
scheduling {
availability_domain = # value needed
expose_host_topology = # value needed
maintenance_interval = # value needed
min_node_cpus = # value needed
on_host_maintenance = # value needed
}
}
Missing doc report (experimental)The following resources have fields missing in documents.
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 42 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @tanvinsharma, @ScottSuarez VCR tests complete for 658db96! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d5fda65: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_instance" "primary" {
scheduling {
maintenance_interval = # value needed
}
}
Resource: resource "google_compute_instance_from_machine_image" "primary" {
scheduling {
availability_domain = # value needed
expose_host_topology = # value needed
maintenance_interval = # value needed
min_node_cpus = # value needed
}
}
Resource: resource "google_compute_instance_from_template" "primary" {
scheduling {
availability_domain = # value needed
expose_host_topology = # value needed
maintenance_interval = # value needed
min_node_cpus = # value needed
on_host_maintenance = # value needed
}
}
Missing doc report (experimental)The following resources have fields missing in documents.
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 41 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @tanvinsharma, @ScottSuarez VCR tests complete for d5fda65! |
d5fda65 to
b4bd849
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b4bd849: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_instance" "primary" {
scheduling {
maintenance_interval = # value needed
}
}
Resource: resource "google_compute_instance_from_machine_image" "primary" {
scheduling {
availability_domain = # value needed
expose_host_topology = # value needed
maintenance_interval = # value needed
min_node_cpus = # value needed
}
}
Resource: resource "google_compute_instance_from_template" "primary" {
scheduling {
availability_domain = # value needed
expose_host_topology = # value needed
maintenance_interval = # value needed
min_node_cpus = # value needed
on_host_maintenance = # value needed
}
}
Missing doc report (experimental)The following resources have fields missing in documents.
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @tanvinsharma, @ScottSuarez VCR tests complete for b4bd849! |
Adds
expose_host_topologyfield toschedulingforgoogle_compute_instance,google_compute_instance_template, andgoogle_compute_region_instance_templateacross GA (v1) andbeta.This field allows exposing host topology / hashed physical host ID to the VM instance.
Tested against GCE API and verified with acceptance tests on
google_compute_instance,google_compute_instance_template, andgoogle_compute_region_instance_template.