container: add skip_node_pool_refresh to google_container_cluster data source - #18880
Open
ralbertazzi wants to merge 2 commits into
Open
container: add skip_node_pool_refresh to google_container_cluster data source#18880ralbertazzi wants to merge 2 commits into
ralbertazzi wants to merge 2 commits into
Conversation
…a source Expose the existing resource-side performance flag on the corresponding data source. The data source read path already honors the flag via flattenClusterNodePools; this makes the field settable instead of computed-only, so users can opt out of the node pool read on clusters with a high node pool count. Fixes hashicorp/terraform-provider-google#29171 🤖 Generated with [OpenCode](https://opencode.ai) (GPT-5.6 Terra)
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
🤖 Generated with [OpenCode](https://opencode.ai) (GPT-5.6 Luna)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes hashicorp/terraform-provider-google#29171
Description
The
skip_node_pool_refreshperformance flag added to thegoogle_container_clusterresource in #17968 is not usable from the corresponding data source:DatasourceSchemaFromResourceSchemacopies every resource field as computed-only, so the flag exists on the data source but cannot be set.The data source read path already honors the flag —
datasourceContainerClusterReaddelegates toresourceContainerClusterRead, which skips the node pool flattening inflattenClusterNodePoolswhen the flag is set. This PR makes the field settable viaAddOptionalFieldsToSchema, so users with clusters that have a high node pool count can opt out of the node pool read:When enabled, the data source's
node_poolattribute remains empty ([]), matching the resource-side behavior.Testing
googleprovider locally and confirmed the diff is scoped to the data source, its test, and the data source docsgo vet/go test ./google/services/container/pass (includingTestUnitFlattenClusterNodePools)skip_node_pool_refreshas Optional whilenode_poolstays computed-onlyTestAccContainerClusterDatasource_skipNodePoolRefresh, mirroring the existing data source tests, which assertsnode_pool.# = 0when the flag is set (requires a real GCP project / VCR cassette to run)Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.
🤖 Generated with OpenCode (GPT-5.6 Terra)