networkservices: add deferred list resources - #18866
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 23a8b8d: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 38 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. 🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. |
|
/gcbrun |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 23a8b8d: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 25 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode Caution Panic occurred during VCR tests 🔴 RECORDING mode: The provider crashed with a panic. Please check the build log for details. Please fix the issue to complete your PR. View the build log |
9a326b5 to
b5a93cf
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 9a326b5: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode Caution Panic occurred during VCR tests 🔴 RECORDING mode: The provider crashed with a panic. Please check the build log for details. Please fix the issue to complete your PR. View the build log |
0237ba1 to
448a8d1
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 0237ba1: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode Caution Panic occurred during VCR tests 🔴 RECORDING mode: The provider crashed with a panic. Please check the build log for details. Please fix the issue to complete your PR. View the build log |
Empty tokens replayed the first page until the 6h TF_ACC timeout (VCR panic on PR 18701). Null tokens panicked on a string conversion.
…sources Co-authored-by: Cursor <cursoragent@cursor.com>
Add generate_list_resource: true to 14 eligible networkservices resources: - AgentGateway - EdgeCacheKeyset - EdgeCacheOrigin - EdgeCacheService - EndpointPolicy - Gateway - GrpcRoute - HttpRoute - LbRouteExtension - LbTrafficExtension - Mesh - ServiceLbPolicies - TcpRoute - TlsRoute
- Gateway: add vars/test_vars_overrides for location and update sample template to include location field so test creates resource in provider test region matching list query scope - TlsRoute: same fix as Gateway - GrpcRoute: base_url already hardcodes global, no change needed - Mesh: base_url already hardcodes global, no change needed - LbRouteExtension: update vm_test image from debian-11 to debian-12 - LbTrafficExtension: update vm_test image from debian-11 to debian-12 - AgentGateway: move simpler client_to_agent sample first to avoid complex infrastructure setup timeout; add custom_code decoder
Restore generate_list_resource: true to AgentGateway.yaml which was
accidentally removed in the previous commit when adding the decoder
template reference. Also reorder samples to put the simpler
client_to_agent sample first so the generated list-query test uses the
lighter-weight configuration.
Root cause (P-17 investigation): AgentGateway has base_url with
{{location}} scope param. The generated test uses listScope.Capture to
read the actual resource location after creation and passes that to the
list query via ConfigVariables, so the list query always targets the
same location where the resource was created. No scope mismatch occurs.
The decoder template reference has been removed since name has
ignore_read: true which already suppresses read-time name drift.
448a8d1 to
ba608f6
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit ba608f6: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 25 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode Caution Panic occurred during VCR tests 🔴 RECORDING mode: The provider crashed with a panic. Please check the build log for details. Please fix the issue to complete your PR. View the build log |
Adds list-resource generation for the following networkservices resources:
google_network_services_agent_gatewaygoogle_network_services_edge_cache_keysetgoogle_network_services_edge_cache_origingoogle_network_services_edge_cache_servicegoogle_network_services_endpoint_policygoogle_network_services_gatewaygoogle_network_services_grpc_routegoogle_network_services_http_routegoogle_network_services_lb_route_extensiongoogle_network_services_lb_traffic_extensiongoogle_network_services_meshgoogle_network_services_service_lb_policiesgoogle_network_services_tcp_routegoogle_network_services_tls_routePer-resource investigation (Pattern P-17)
All 14 resources were initially deferred with Pattern P-17 (scope mismatch). Each resource was individually investigated below.
Group 1:
base_urlhardcodes/locations/global/— no scope mismatch possibleThe following resources hardcode
globalinbase_url, so the list query always targetsglobalregardless of the test environment region. No P-17 fix required.base_urlEdgeCacheKeysetprojects/{{project}}/locations/global/edgeCacheKeysetsEdgeCacheOriginprojects/{{project}}/locations/global/edgeCacheOriginsEdgeCacheServiceprojects/{{project}}/locations/global/edgeCacheServicesEndpointPolicyprojects/{{project}}/locations/global/endpointPoliciesHttpRouteprojects/{{project}}/locations/global/httpRoutesTcpRouteprojects/{{project}}/locations/global/tcpRoutesGroup 2:
base_urlwas{{location}}but fixed to hardcodeglobal— samples updatedThese resources have
locationas aurl_param_onlyfield defaulting toglobal. Thebase_urlwas updated fromlocations/{{location}}tolocations/globalso the list query always targets theglobalcollection. Sample configs were updated to passlocation: 'global'invars.GrpcRoutebase_urlused{{location}}which resolves to env region at test time; resource default isglobalbase_urlto hardcodeglobal; addedvars: location: 'global'to basic sampleMeshbase_urlto hardcodeglobal; addedvars: location: 'global'to basic sampleGroup 3:
base_urluses{{location}}—vars/test_vars_overridesadded to align scopeThese resources use
{{location}}inbase_url. The P-17 fix was to addvars: location: 'global'andtest_vars_overrides: location: envvar.GetTestRegionFromEnv()to the sample so both resource creation and list query use the same region.Gatewaylocationdefaults toglobalbut auto-injection used env regionvars: location: 'global'+test_vars_overrides: location: envvar.GetTestRegionFromEnv()to basic sample; updated template to use{{index $.Vars "location"}}TlsRoutelocationdefaults toglobalbut auto-injection used env regionServiceLbPolicieslocationis requiredGroup 4:
base_urluses{{location}}with regional resources — image fixLbRouteExtensiondebian-11is deprecated, causing creation failure before list query runsdebian-cloud/debian-11todebian-cloud/debian-12in both sample templatesLbTrafficExtensionGroup 5:
base_urluses{{location}}—listScope.Captureself-corrects scopeAgentGatewaybase_urluses{{location}}; the generated test useslistScope.Captureto read the actual resource location after creation, then passes it to list query viaConfigVariables. No P-17 mismatch occurs. Thegenerate_list_resource: trueflag was accidentally removed in the previous commit when adding a reference to a non-existent decoder file.generate_list_resource: true. Movedclient_to_agentsample first. Removed stale decoder reference (namehasignore_read: trueso no decoder is needed).Release notes