Skip to content

Add exclude_from_gen_ai_features field to Datastore#16565

Open
ranlz77 wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
ranlz77:add-exclude-from-gen-ai-features
Open

Add exclude_from_gen_ai_features field to Datastore#16565
ranlz77 wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
ranlz77:add-exclude-from-gen-ai-features

Conversation

@ranlz77
Copy link
Copy Markdown

@ranlz77 ranlz77 commented Feb 27, 2026

google_discovery_engine_data_store.

This PR adds exclude_from_gen_ai_features as a valid field to the google_discovery_engine_data_store resource.
FIxes b/483792089

Release Note Template for Downstream PRs (will be copied)

discoveryengine: added `exclude_from_gen_ai_features` field to `google_discovery_engine_data_store` resource

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Feb 27, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 27, 2026
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions Bot requested a review from SirGitsalot February 27, 2026 08:31
@ranlz77 ranlz77 force-pushed the add-exclude-from-gen-ai-features branch from dcf3ea9 to 495f270 Compare February 27, 2026 08:49
Copy link
Copy Markdown
Member

@SirGitsalot SirGitsalot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if this is fully rolled out? It looks like there is still a visibility label on the field. I just kicked off the test run, that might tell us.

@modular-magician modular-magician added service/discoveryengine and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Feb 27, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 99 insertions(+))
google-beta provider: Diff ( 4 files changed, 99 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 112 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 40
Passed tests: 38
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • discoveryengine

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreExcludeFromGenAiFeaturesExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreExcludeFromGenAiFeaturesExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@ranlz77
Copy link
Copy Markdown
Author

ranlz77 commented Feb 28, 2026

@SirGitsalot Thanks for the heads up! I noticed the field was available in the Cloud Console's payload, but it is not mentioned in the v1 API document of projects.locations.collections.dataStores. So you're right, it might still be behind a visibility gate.

@github-actions github-actions Bot requested a review from SirGitsalot February 28, 2026 01:24
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 4, 2026

@SirGitsalot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 6, 2026

@GoogleCloudPlatform/terraform-team @SirGitsalot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link
Copy Markdown

@SirGitsalot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @SirGitsalot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @SirGitsalot This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @SirGitsalot This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 3, 2026

@GoogleCloudPlatform/terraform-team @SirGitsalot This PR has been waiting for review for 4 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @SirGitsalot This PR has been waiting for review for 5 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @SirGitsalot This PR has been waiting for review for 6 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @SirGitsalot This PR has been waiting for review for 7 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants