Skip to content

compute: convert service_attachment_test.go file to .go.tmpl#16555

Merged
BBBmau merged 3 commits intoGoogleCloudPlatform:mainfrom
BBBmau:service_attacment_test_tmpl_converion
Mar 2, 2026
Merged

compute: convert service_attachment_test.go file to .go.tmpl#16555
BBBmau merged 3 commits intoGoogleCloudPlatform:mainfrom
BBBmau:service_attacment_test_tmpl_converion

Conversation

@BBBmau
Copy link
Copy Markdown
Collaborator

@BBBmau BBBmau commented Feb 26, 2026

This conversion is from #16493

the PR introduced a beta only field but the test file itself is a regular go file resulting in the nightly test running the field on both GA and beta instead of just beta.

Having it a .go.tmpl will allow us to prevent the test on the beta only field to be generated on google-beta

TeamCity Build which shows the error from using field in GA provider

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 123 deletions(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1367
Passed tests: 1277
Skipped tests: 90
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

@BBBmau BBBmau requested a review from hao-nan-li February 26, 2026 23:09
@aishwaryavora
Copy link
Copy Markdown
Member

Thanks for the fix.

@aishwaryavora
Copy link
Copy Markdown
Member

@BBBmau and @hao-nan-li should we merge this PR?

@BBBmau BBBmau added this pull request to the merge queue Mar 2, 2026
Merged via the queue into GoogleCloudPlatform:main with commit f16b8e5 Mar 2, 2026
22 checks passed
@BBBmau BBBmau deleted the service_attacment_test_tmpl_converion branch March 2, 2026 17:25
habh-11 pushed a commit to habh-11/magic-modules that referenced this pull request Mar 2, 2026
aditikumarii-google pushed a commit to aditikumarii-google/magic-modules that referenced this pull request Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants