feat(cloudrun): upgrade helloworld sample to java 25 #10222
Conversation
product-auto-label
bot
added
samples
Summary of ChangesHello @alarconesparza, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the Cloud Run helloworld Java sample by upgrading its core Java version to 25. This involves updating the Docker build and runtime images, adjusting Maven compiler settings, and refreshing key dependencies and build plugins like Spring Boot and Jib, while also integrating JaCoCo for code coverage. The changes ensure the sample leverages the latest Java features and ecosystem improvements. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades the helloworld sample to Java 25 and updates several dependencies. However, the changes rely on Docker images and Maven artifacts that are not publicly available. This will cause the build to fail for anyone trying to use this sample. My review comments pinpoint each of these issues. For the sample to be buildable, all dependencies must be available in public repositories.
| # Use the official maven image to create a build artifact. | ||
| # https://hub.docker.com/_/maven | ||
| FROM maven:3-eclipse-temurin-17-alpine as builder | ||
| FROM maven:3-eclipse-temurin-25-alpine as builder |
There was a problem hiding this comment.
The Docker base image maven:3-eclipse-temurin-25-alpine does not appear to be publicly available on Docker Hub. This will cause the Docker build to fail. Please use a valid, existing image tag.
| # Use Eclipse Temurin for base image. | ||
| # https://docs.docker.com/develop/develop-images/multistage-build/#use-multi-stage-builds | ||
| FROM eclipse-temurin:17.0.16_8-jre-alpine | ||
| FROM eclipse-temurin:25.0.1_8-jre-alpine |
There was a problem hiding this comment.
The Docker base image eclipse-temurin:25.0.1_8-jre-alpine does not appear to be publicly available on Docker Hub. This will cause the Docker build to fail. Please use a valid, existing image tag.
| <groupId>com.google.cloud.samples</groupId> | ||
| <artifactId>shared-configuration</artifactId> | ||
| <version>1.2.0</version> | ||
| <version>1.2.2</version> |
There was a problem hiding this comment.
The parent POM version 1.2.2 for com.google.cloud.samples:shared-configuration is not available in Maven Central (the latest public version is 1.2.0). Using a non-existent version will cause the build to fail.
| <spring-boot.version>3.2.2</spring-boot.version> | ||
| <maven.compiler.target>25</maven.compiler.target> | ||
| <maven.compiler.source>25</maven.compiler.source> | ||
| <spring-boot.version>3.5.9</spring-boot.version> |
There was a problem hiding this comment.
The Spring Boot version 3.5.9 is not a public release and is not available in Maven Central. This will cause dependency resolution to fail during the build.
| <groupId>com.google.cloud.tools</groupId> | ||
| <artifactId>jib-maven-plugin</artifactId> | ||
| <version>3.4.0</version> | ||
| <version>3.5.1</version> |
There was a problem hiding this comment.
The jib-maven-plugin version 3.5.1 is not available in Maven Central, which will cause the build to fail. The latest public version is 3.4.3.
| <version>3.5.1</version> | |
| <version>3.4.3</version> |
| <plugin> | ||
| <groupId>org.jacoco</groupId> | ||
| <artifactId>jacoco-maven-plugin</artifactId> | ||
| <version>0.8.14</version> |
There was a problem hiding this comment.
The jacoco-maven-plugin version 0.8.14 is not available in Maven Central, which will cause the build to fail. The latest public version is 0.8.12.
| <version>0.8.14</version> | |
| <version>0.8.12</version> |
1 participant
Description
Fixes internal b/470273769
Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only