Parameterize kernel download and nvidia installer options.#97
Open
clkao wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
Open
Parameterize kernel download and nvidia installer options.#97clkao wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
clkao wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
Conversation
This allows reusing the entrypoint by overriding how the kernel is downloaded and where to look for it. As an alternative to GoogleCloudPlatform#91, you can use this for centos by setting the following extra env in the daemonset: ``` - name: KERNEL_SOURCE_DOWNLOAD_COMMAND value: 'yum install -y kernel-devel-${KERNEL_VERSION}' - name: NVIDIA_INSTALLER_EXTRA_ARGS value: '--kernel-source-path=/usr/src/kernels/${KERNEL_VERSION}' ``` It is also possible to use this for airgapped install provided the kernel-devel package and .run file are available on the host: ``` - name: NVIDIA_DRIVER_DOWNLOAD_URL value: file:///root/usr/src/NVIDIA-Linux-x86_64-384.130.run - name: KERNEL_SOURCE_DOWNLOAD_COMMAND value: 'echo' - name: NVIDIA_INSTALLER_EXTRA_ARGS value: '--kernel-source-path=/root/usr/src/kernels/${KERNEL_VERSION}' ```
Author
|
per #91 (comment) and #54, installers for additional distributions aren't likely to be merged due to maintainability. If entrypoint.sh becomes common enough, we can rename ubuntu/ to generic/, and have additional Dockerfile.$distribution (that might not be tested and supported). This could be the case for the minikube installer too, as its entrypoint is largely the same. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows reusing the entrypoint by overriding how the kernel is downloaded and where to look for it.
As an alternative to #91, you can use this for centos by setting the following extra env in the daemonset:
It is also possible to use this for airgapped install provided the kernel-devel package and .run file are available on the host:
Note that you'd still need a centos-based installer image using the Dockerfile from #91, but with the same entrypoint.sh