Using hybrid method to combine allocatable wait and flock wait#514
Closed
zxqlxy wants to merge 3 commits intoGoogleCloudPlatform:masterfrom
Closed
Using hybrid method to combine allocatable wait and flock wait#514zxqlxy wants to merge 3 commits intoGoogleCloudPlatform:masterfrom
zxqlxy wants to merge 3 commits intoGoogleCloudPlatform:masterfrom
Conversation
linxiulei
suggested changes
Aug 25, 2025
zxqlxy
force-pushed
the
xinyunliu/master
branch
from
d21db02 to
273e410
Compare
zxqlxy
force-pushed
the
xinyunliu/master
branch
from
273e410 to
8c58f5c
Compare
linxiulei
reviewed
Sep 4, 2025
| glog.Infof("Failed to build kube client: %v", err) | ||
| return | ||
| } | ||
| nodeName, err := util.GetEnv(nodeNameEnv) |
Contributor
There was a problem hiding this comment.
This would require a change in DaemonSet yaml, right? should we getHostname if failed to get this env var?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the local lock to avoid deadlock when we enable the maxSurge rollingUpdate strategy as there will be two gpu-device-plugin running at the same time during the rollingUpdate. Use remote node status when there is no lock there to prevent deadlock though a little bit slower.