Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
X25519MLKEM768, IANA0x11ec) support inREADME.mdand CLI--help(cmd/root.go/docs/cmd/cloud-sql-proxy.md), including:v2.15.2+) and v1 (v1.37.6+/v1.38.4+), Go 1.24+ source builds, andgcloud sql connectbinary resolution.X25519when connecting to servers that do not yet advertise hybrid PQC.GODEBUG=tlsmlkem=0(for example, when troubleshooting middleboxes or firewalls that drop or reset largerClientHellomessages).internal/proxy/pqc_test.go) covering:X25519MLKEM768(0x11ec) negotiation and PQC-only server connections.X25519andP-256(HelloRetryRequest) fallback against classical-only TLS 1.3 servers.GODEBUG=tlsmlkem=0client-side opt-out (against both hybrid-capable and PQC-only servers) and explicitGODEBUG=tlsmlkem=1.Testing
go test -v -race -count=1 ./internal/proxy -run TestProxyPQCKeyExchangego vet ./...and./build.sh lint