Divide resource Requests and Limits#5945
Divide resource Requests and Limits#5945haykking wants to merge 6 commits intoGoogleCloudPlatform:masterfrom
Conversation
|
Please add verification steps for the benchmark |
| CPUS_PER_POD = flags.DEFINE_string( | ||
| 'kubernetes_scale_pod_cpus', '250m', 'CPU limit per pod' | ||
| REQUEST_CPUS_PER_POD = flags.DEFINE_string( | ||
| 'kubernetes_scale_min_pod_cpus', '250m', 'Min CPU limit per pod' |
There was a problem hiding this comment.
No real need to change the flag name. It's somewhat inconvenient on my end as I then need to modify the scheduling code we have to change this as well. Updating the description is sufficient documentation.
| MEMORY_PER_POD = flags.DEFINE_string( | ||
| 'kubernetes_scale_pod_memory', '250M', 'Memory limit per pod' | ||
| LIMIT_CPUS_PER_POD = flags.DEFINE_string( | ||
| 'kubernetes_scale_max_pod_cpus', '250m', 'Max CPU limit per pod' |
There was a problem hiding this comment.
But I think we also chatted offline about just needing one number for both limits & requests, so will wait on the larger modification to give next review.
|
I returned the old names to the variables |
|
Fair enough, very small indeed but all that's needed. I'll approve & we can check back in with Rich when he's back as well. |
|
Per our chat conversation with Rich, this actually does not make sense right? Should it be reverted? |
|
After chat conversation with Rich, we have two options:
I can do it as we decide is more convenient. |
4 participants
New variables responsible for Limits and Requests were created and changed.
A new Limits section was created in the Kubernetes manifest.