Skip to content

Fix bugs in writeBambuOutput. #501

Merged
cying111 merged 2 commits intodevel_pre_v4from
Multiplex_Fix_incompatibleCounts
Jan 15, 2026
Merged

Fix bugs in writeBambuOutput. #501
cying111 merged 2 commits intodevel_pre_v4from
Multiplex_Fix_incompatibleCounts

Conversation

@SuiYue-2308
Copy link
Copy Markdown
Collaborator

Correct the order of incompatibleCounts.mtx to match to gene.tsv.

@lingminhao
Copy link
Copy Markdown
Collaborator

lingminhao commented Dec 12, 2025

@SuiYue-2308 , I suggest to fix the order of GENEID directly within the transcriptToGeneExpression(se) instead, then you do not have to reorder metadata(se)$incompatibleCounts anymore.

@SuiYue-2308
Copy link
Copy Markdown
Collaborator Author

@SuiYue-2308 , I suggest to fix the order of GENEID directly within the transcriptToGeneExpression(se) instead, then you do not have to reorder metadata(se)$incompatibleCounts anymore.

Hi @lingminhao , thank you for the suggestion. I think this is a better way with minimal code changes. I’ve tested the results after your commit, and everything looks good to me. Thanks!

@SuiYue-2308 SuiYue-2308 changed the base branch from Multiplex_Major_Patch to devel_pre_v4 January 9, 2026 05:12
@cying111 cying111 merged commit 8ca8e90 into devel_pre_v4 Jan 15, 2026
@cying111 cying111 deleted the Multiplex_Fix_incompatibleCounts branch January 15, 2026 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants